Sergei,
usb.c contains definitions which are more applicable to DA8xx platform
and is not shared in any way with other DaVinci platform devices (DMxxxx).
That is the reason I had created usb_davinci.h file. The functionality in this
file contains represents the capability of DMxxx devices as compared to DA8xx.
I would like to recommend that the usb.h file be changed to usb_da8xx.h in this
way there will be clear representation.
Regards
swami
-----Original Message-----
From: Sergei Shtylyov [mailto:[email protected]]
Sent: Wednesday, October 07, 2009 11:11 PM
To: Subbrathnam, Swaminathan
Cc: [email protected]; [email protected]
Subject: Re: [PATCH 2/7] Subscribes for USB resources for TI DM644x EVM
platform.
Hello.
Swaminathan S wrote:
> This patch implements the support for USB VBUS, PHY control, DM644x USB memory
> mapsi,
Maps?
> IRQ, USB Mode. It initializes for a single instance of MUSB controller.
>
> Signed-off-by: Swaminathan S <[email protected]>
>
[...]
> diff --git a/arch/arm/mach-davinci/include/mach/usb_davinci.h
> b/arch/arm/mach-davinci/include/mach/usb_davinci.h
> new file mode 100644
> index 0000000..02f8af7
> --- /dev/null
> +++ b/arch/arm/mach-davinci/include/mach/usb_davinci.h
>
Please don't create yet another header where <mach/usb.h> was
intended to be used...
> @@ -0,0 +1,41 @@
> +/*
> + * This file contains the processor specific USB definitions
> + * of the TI DaVinci platforms.
> + *
> + * Copyright (C) 2009 Texas Instruments.
WBR, Sergei
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
