Hello, Couple of (styling related) comments below:
On Tue, Nov 10, 2009 at 16:52:00, Andrey Porodko wrote: > The Neuros OSD 2.0 is the hardware component of the Neuros Open > Internet Television Platform. Hardware is very close to Ti DM644X-EVM board. > It has: DM6446M02 module with 256MB NAND, 256MB RAM, TLV320AIC32 AIC, > USB, Ethernet, SD/MMC, UART, THS8200, TVP7000 for video. > Additionaly realtime clock, IR remote control receiver, > IR Blaster based on MSP430 (firmware although is different > from used in DM644X-EVM), internal ATA-6 3.5” HDD drive > with PATA interface, two muxed red-green leds. > > For more information please refer to > http://wiki.neurostechnology.com/index.php/OSD_2.0_HD > > Signed-off-by: Andrey Porodko <[email protected]> [...] > diff --git a/arch/arm/mach-davinci/board-neuros-osd2.c > b/arch/arm/mach-davinci/board-neuros-osd2.c > new file mode 100644 > index 0000000..d0a1462 > --- /dev/null > +++ b/arch/arm/mach-davinci/board-neuros-osd2.c > @@ -0,0 +1,306 @@ > +/* > + * Neuros Technologies OSD2 board support > + * > + * Modified from original 644X-EVM board support. > + * 2008 (c) Neuros Technology, LLC. > + * 2009 (c) Jorge Luis Zapata Muga <[email protected]> > + * 2009 (c) Andrey A. Porodko <[email protected]> > + * > + * The Neuros OSD 2.0 is the hardware component of the Neuros Open > + * Internet Television Platform. Hardware is very close to Ti TI > + * DM644X-EVM board. It has: > + * DM6446M02 module with 256MB NAND, 256MB RAM, TLV320AIC32 AIC, > + * USB, Ethernet, SD/MMC, UART, THS8200, TVP7000 for video. > + * Additionaly realtime clock, IR remote control receiver, > + * IR Blaster based on MSP430 (firmware although is different > + * from used in DM644X-EVM), internal ATA-6 3.5” HDD drive > + * with PATA interface, two muxed red-green leds. > + * > + * For more information please refer to > + * http://wiki.neurostechnology.com/index.php/OSD_2.0_HD License information is missing. > + * > + * 10/2009 Initial code with nand flash, fb, ide, ethernet, leds-gpio, > + * usb support. No need of history in source files. git does it for us. > + */ > +#include <linux/platform_device.h> > +#include <linux/gpio.h> > + Unnecessary empty line > +#include <linux/mtd/partitions.h> > + > +#include <asm/mach-types.h> > +#include <asm/mach/arch.h> > + > +#include <mach/dm644x.h> > +#include <mach/i2c.h> > +#include <mach/serial.h> > +#include <mach/mux.h> > +#include <mach/nand.h> > +#include <mach/mmc.h> > +#include <mach/usb.h> > + > +#define NEUROS_OSD2_PHY_MASK (0x2) > +#define NEUROS_OSD2_MDIO_FREQUENCY (2200000) /* PHY bus frequency */ No need of parenthesis here... > + > +#define DAVINCI_CFC_ATA_BASE 0x01C66000 > + > +#define DAVINCI_ASYNC_EMIF_CONTROL_BASE 0x01e00000 > +#define DAVINCI_ASYNC_EMIF_DATA_CE0_BASE 0x02000000 > + > +#define LXT971_PHY_ID (0x001378e2) > +#define LXT971_PHY_MASK (0xfffffff0) ... and here. > + > +#define NTOSD2_AUDIOSOC_I2C_ADDR 0x18 > +#define NTOSD2_MSP430_I2C_ADDR 0x59 > +#define NTOSD2_MSP430_IRQ 2 > + [...] > + > +static void __init > +davinci_ntosd2_map_io(void) This stands out since other function definitions aren’t broken up like this. > +{ > + dm644x_init(); > +} > + > +/* > + I2C initilization Spelling.. :) > +*/ > +static struct davinci_i2c_platform_data ntosd2_i2c_pdata = { > + .bus_freq = 20 /* kHz */, > + .bus_delay = 100 /* usec */, > +}; > + [...] > + > +static __init void davinci_ntosd2_init(void) > +{ > + struct clk *aemif_clk; > + struct davinci_soc_info *soc_info = &davinci_soc_info; > + > + aemif_clk = clk_get(NULL, "aemif"); > + clk_enable(aemif_clk); > + > + if (HAS_ATA) { > + if (HAS_NAND) > + pr_warning("WARNING: both IDE and Flash are " > + "enabled, but they share AEMIF pins.\n" > + "\tDisable IDE for NAND/NOR support.\n"); > + davinci_cfg_reg(DM644X_HPIEN_DISABLE); > + davinci_cfg_reg(DM644X_ATAEN); > + davinci_cfg_reg(DM644X_HDIREN); > + platform_device_register(&ide_dev); > + } else if (HAS_NAND) { > + davinci_cfg_reg(DM644X_HPIEN_DISABLE); > + davinci_cfg_reg(DM644X_ATAEN_DISABLE); > + > + /* only one device will be jumpered and detected */ > + if (HAS_NAND) > + platform_device_register( > + &davinci_ntosd2_nandflash_device); > + } > + > + platform_add_devices(davinci_ntosd2_devices, > + ARRAY_SIZE(davinci_ntosd2_devices)); > + > + /* Initialize I2C interface specific for this board */ > + ntosd2_init_i2c(); > + > + davinci_serial_init(&uart_config); > + dm644x_init_asp(&dm644x_ntosd2_snd_data); > + > + soc_info->emac_pdata->phy_mask = NEUROS_OSD2_PHY_MASK; > + soc_info->emac_pdata->mdio_max_freq = NEUROS_OSD2_MDIO_FREQUENCY; > + > + davinci_setup_usb(1000, 8); > + /* Mux the pins to be GPIOS, VLYNQEN is already done at startup */ > + /* The AEAWx. are five new AEAW pins than can be muxed by separate. > + When set to 0, those pins can be used for GPIOs. For our board, > + we need gpio(10,11,12,13) to support the leds we have connected > + on those pins. > + */ Please follow the preferred multi-line commenting described in Documentation/CodingStyle chapter 8. Thanks, Sekhar
_______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
