Hi Sergei, Much appreciation for the thorough review, your feedback was excellent. I will roll in v2 modifications as per your comments.
[...] > Shouldn't the above be in gpio.c? > I do think devices-*.c file is a bad place for GPIO code. Since this GPIO controller is specific to the tnetv107x device, I thought it would be best to keep it in here. I kinda expected stronger opposition to having this code in davinci-wide gpio.c [...] > Whole megabyte for cp_intc? I can cut that down to 16K and leave a hole there, but it doesn't really help from a VM usage efficiency perspective, since VMALLOC_END would remain the same. To make it VM-efficient, we would presumably need to get rid of the IO_ADDRESS nastiness. Regards Cyril. _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
