Hello.

Chemparathy, Cyril wrote:

Much appreciation for the thorough review, your feedback was excellent.
I will roll in v2 modifications as per your comments.

[...]
   Shouldn't the above be in gpio.c?
   I do think devices-*.c file is a bad place for GPIO code.

Since this GPIO controller is specific to the tnetv107x device, I thought
it would be best to keep it in here.  I kinda expected stronger opposition to
having this code in davinci-wide gpio.c

You may introduce gpio-tnetv107x.c. But devices-tnetv107x.c certainly doesn't fit this purpose -- it's for the platform devices.

WBR, Sergei

_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to