Cyril Chemparathy <[email protected]> writes:
> This patch replaces the jtag id base info in davinci_soc_info with a physical
> address which is then ioremap()ed within common code.
>
> This patch (in combination with a similar change for PSC) will allow us to
> eliminate the SYSCFG nastiness in DA8xx code.
>
> Signed-off-by: Cyril Chemparathy <[email protected]>
me likey
[...]
> -static struct davinci_id * __init davinci_get_id(u32 jtag_id)
> +static int __init davinci_init_id(struct davinci_soc_info *soc_info)
> {
> - int i;
> - struct davinci_id *dip;
> - u8 variant = (jtag_id & 0xf0000000) >> 28;
> - u16 part_no = (jtag_id & 0x0ffff000) >> 12;
> + int i;
> + struct davinci_id *dip;
> + u8 variant;
> + u16 part_no;
> + void __iomem *base;
> +
> + base = ioremap(davinci_soc_info.jtag_id_reg, SZ_4K);
> + if (!base) {
> + pr_err("Unable to map JTAG ID register\n");
> + return -EINVAL;
minor nit: use -ENOMEM for failed allocations.
Kevin
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
