Sergei Shtylyov <[email protected]> writes: > Hello. > > Cyril Chemparathy wrote: > >> Hi Sergei, >> >> [...] >> >>> void __iomem *da8xx_syscfg0_base; >>> void __iomem *da8xx_syscfg1_base; >>> +EXPORT_SYMBOL_GPL(da8xx_syscfg0_base); >>> >> >> Would it be an overkill to pass as a resource and ioremap in >> usb_hcd_da8xx_probe() instead? >> > > Passing a resource is certainly an overkill. >
Disagree. I would much rather see this as a resource than as a global variable. What happens if/when this HW block is used on a non-da8xx device? Kevin _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
