Hi Sergei,
On Mon, May 03, 2010 at 21:52:18, Sergei Shtylyov wrote:
> Hello
>
> Kevin Hilman wrote:
>
> >>> Hi Sergei,
> >>>
> >>> [...]
> >>>
> >>>
> >>>> void __iomem *da8xx_syscfg0_base;
> >>>> void __iomem *da8xx_syscfg1_base;
> >>>> +EXPORT_SYMBOL_GPL(da8xx_syscfg0_base);
> >>>>
> >>>>
> >>> Would it be an overkill to pass as a resource and ioremap in
> >>> usb_hcd_da8xx_probe() instead?
> >>>
> >>>
> >> Passing a resource is certainly an overkill.
> >>
>
> Do you really want me to pass the single CFGCHIP2 register as a
> resource?! Since the rest of the system config. registers don't belong
> to USB...
You could have platform data callback function pointers
to for the various functionality that CFGCHIP2 provides.
Something like:
pdata->setup_phy_clk()
pdata->phy_{enable|disable}()
...
Future platforms doing these operations in a different manner
can re-define these functions (or not define them at all as the
case may be).
Thanks,
Sekhar
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
