On Fri, May 07, 2010 at 03:57:41, Kevin Hilman wrote: > Sekhar Nori <[email protected]> writes: > > > In the edma driver, some lines are broken up at really > > odd places to meet the 80 chars per line rule. This make > > reading those parts particularly difficult. > > > > This patch fixes that by creating a few lines over 80 > > characters, but I feel it still improves readability over > > what is existing currently. > > This version is more readable (barring similar alignmen comments from > previous patch) but... this code really needs some subroutines > (inlines?) to make it so that there aren't lines > 80 characters. > > That would solve all the problems, although requiring a little more > work on your part.
True, and I had half-seen this comment coming :) Will rework. Thanks, Sekhar _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
