> On Sun, Mar 07, 2010 at 18:05:54, Nori, Sekhar wrote: > > The rtc-omap driver currently hardcodes the RTC wakeup > capability > > to be "not capable". While this seems to be true for > existing OMAP1 > > boards which are not wired for this, the > DA850/OMAP-L138 SoC, the > > RTC can always be wake up source from its "deep sleep" > mode.
Good. Linux has work to do yet getting wake events to behave, and I keep thinking that RTC support is the best place for such work to start ... (since most RTCs seem to issue wake events, even on ACPI/PC hardware). So having RTCs do this right is forward motion, and will help (I'd hope!) get other wake event sources working too. That driver, as you know, started with OMAP1 where few boards were actually wired so the RTC would wake. Which is why it ignored the wake events ... :( > > > > This patch lets the wakeup capability to be set from > platform data and > > does not override the setting from the driver. For > DA850/OMAP-L138, this > > is done from > arch/arm/mach-davinci/devices-da8xx.c:da8xx_register_rtc() > > > > Note that this patch does not change the behavior on > any existing OMAP1 > > board since the platform device registration sets the > wakeup capability > > to 0 by default. > > Dave, would you please ack this patch if you are > satisfied? I don't see how it could work, since it always sets the wake capability to the default of "can't wake"... Even if the board *can* wake... The model I've worked with is that for devices which can issue wake events, the board init code sets that flag, and the driver responds appropriately. Presumably that could work here too... > Can you please ack this patch if it looks good (or suggest > any other changes you would like to see)? > > device_init_wakeup(&pdev->dev, 0); Having that line seems to defeat the purpose... _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
