Hi Dave,
On Thu, May 20, 2010 at 22:21:59, David Brownell wrote:
>
> > > This patch lets the wakeup capability to be set from
> > platform data and
> > > does not override the setting from the driver. For
> > DA850/OMAP-L138, this
> > > is done from
> > arch/arm/mach-davinci/devices-da8xx.c:da8xx_register_rtc()
> > >
> > > Note that this patch does not change the behavior on
> > any existing OMAP1
> > > board since the platform device registration sets the
> > wakeup capability
> > > to 0 by default.
Just to be clear, I was actually referring to the fact
that the device_initialize() in drivers/base/core.c is
already clearing the 'can wake-up' flag to 0, so there
should be no need to do so again in the driver.
> > > Dave, would you please ack this patch if you are
> > satisfied?
>
> I don't see how it could work, since it always sets the
> wake capability to the default of "can't wake"... Even if
> the board *can* wake...
Are you referring to da8xx_register_rtc() here? It sets the
'can wake' flag to true.
ret = platform_device_register(&da8xx_rtc_device);
if (!ret)
/* Atleast on DA850, RTC is a wakeup source */
device_init_wakeup(&da8xx_rtc_device.dev, true);
>
> The model I've worked with is that for devices which can issue
> wake events, the board init code sets that flag, and the driver
> responds appropriately. Presumably that could work here too...
Yes, except that the response to the wakeup event is really specific
to DaVinci/DA850 and is handled in arch/arm/mach-davinci/sleep.S, not
in the RTC driver.
>
>
> > Can you please ack this patch if it looks good (or suggest
> > any other changes you would like to see)?
> >
> > device_init_wakeup(&pdev->dev, 0);
>
> Having that line seems to defeat the purpose...
Agreed, and the patch removes it for that reason.
Thanks,
Sekhar
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
