On Mon, Oct 4, 2010 at 11:51 PM, Nori, Sekhar <[email protected]> wrote:
>
> Hi Victor,
>
> On Tue, Oct 05, 2010 at 01:54:03, [email protected] wrote:
> > From: Victor Rodriguez <[email protected]>
> >
> > This patch adds EMAC support for the Hawkboard-L138 system
> > It is under the machine name "omapl138_hawkboard".
> > This system is based on the da850 davinci CPU architecture.
> >
> > Signed-off-by: Victor Rodriguez <[email protected]>
> > ---
> > arch/arm/mach-davinci/board-omapl138-hawk.c | 49
> > +++++++++++++++++++++++++++
> > 1 files changed, 49 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c
> > b/arch/arm/mach-davinci/board-omapl138-hawk.c
> > index c472dd8..b22c275 100644
> > --- a/arch/arm/mach-davinci/board-omapl138-hawk.c
> > +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c
> > @@ -19,6 +19,55 @@
> >
> > #include <mach/cp_intc.h>
> > #include <mach/da8xx.h>
> > +#include <mach/mux.h>
> > +
> > +#define DA850_EVM_PHY_ID "0:07"
> > +
> > +static const short omapl138_hawk_mii_pins[] = {
> > + DA850_MII_TXEN, DA850_MII_TXCLK, DA850_MII_COL, DA850_MII_TXD_3,
> > + DA850_MII_TXD_2, DA850_MII_TXD_1, DA850_MII_TXD_0, DA850_MII_RXER,
> > + DA850_MII_CRS, DA850_MII_RXCLK, DA850_MII_RXDV, DA850_MII_RXD_3,
> > + DA850_MII_RXD_2, DA850_MII_RXD_1, DA850_MII_RXD_0, DA850_MDIO_CLK,
> > + DA850_MDIO_D,
> > + -1
> > +};
>
> Can this be marked as __initdata as it is only used in an __init function?
>
> Please watch out for section mismatch warnings while doing this. To get
> these warnings, just add "CONFIG_DEBUG_SECTION_MISMATCH=y" on your kernel
> build command.
>
> Also, I assume you are running these patches through 'sparse'. Just add C=1
> to your kernel build command to enable sparse check.
>
I have changed it to
static short omapl138_hawk_mii_pins[] __initdata = {
but still the same warning
>
> > +
> > +static int __init omapl138_hawk_config_emac(void)
> > +{
> > + void __iomem *cfg_chip3_base;
> > + int ret;
> > + u32 val;
> > + struct davinci_soc_info *soc_info = &davinci_soc_info;
> > +
> > + if (!machine_is_omapl138_hawkboard())
> > + return 0;
> > +
> > + cfg_chip3_base = DA8XX_SYSCFG0_VIRT(DA8XX_CFGCHIP3_REG);
> > +
> > + val = __raw_readl(cfg_chip3_base);
> > +
> > + val &= ~BIT(8);
> > + ret = davinci_cfg_reg_list(omapl138_hawk_mii_pins);
> > + pr_info("EMAC: MII PHY configured, RMII PHY will not be"
> > + " functional\n");
>
> Do we really have both MII and RMII phys on the hawk? Seems
> like only MII phy is being setup here.
Sorry for that I have changed to
val &= ~BIT(8);
ret = davinci_cfg_reg_list(omapl138_hawk_mii_pins);
pr_info("EMAC: MII PHY configured\n");
> > +
> > + if (ret)
> > + pr_warning("omapl138_hawk_init: "
> > + "cpgmac/rmii mux setup failed: %d\n", ret);
> > +
> > + /* configure the CFGCHIP3 register for MII */
> > + __raw_writel(val, cfg_chip3_base);
> > +
> > + /* Enable/Disable MII MDIO clock */
>
> Comment seems out of place?
Thanks now is deleted
> > + soc_info->emac_pdata->phy_id = DA850_EVM_PHY_ID;
> > +
> > + ret = da8xx_register_emac();
> > + if (ret)
> > + pr_warning("omapl138_hawk_init: "
> > + "emac registration failed: %d\n", ret);
>
> You can use __func__ to avoid typing out the function name in the
> message.
Changed to
if (ret)
pr_warning("%s: "
"cpgmac/mii mux setup failed: %d\n",__func__, ret);
/* configure the CFGCHIP3 register for MII */
__raw_writel(val, cfg_chip3_base);
soc_info->emac_pdata->phy_id = DA850_EVM_PHY_ID;
ret = da8xx_register_emac();
if (ret)
pr_warning("%s: "
"emac registration failed: %d\n",__func__, ret);
return 0;
> > + return 0;
> > +}
> > +device_initcall(omapl138_hawk_config_emac);
>
> I don't think you need to go the initcall way for initializing EMAC
> on hawk. I believe it was done this way on the EVM since EMAC init
> had a dependency on UI card detection using GPIO expander.
Yes you are right now i have just called the function like this
static __init void omapl138_hawk_init(void)
{
int ret;
davinci_serial_init(&omapl138_hawk_uart_config);
ret = omapl138_hawk_config_emac();
ret = da8xx_register_watchdog();
if (ret)
pr_warning("omapl138_hawk_init: "
"watchdog registration failed: %d\n",
ret);
}
Thanks
Victor Rodriguez
> Thanks,
> Sekhar
>
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
