Hi Victor, On Tue, Oct 05, 2010 at 22:42:40, Victor Rodriguez wrote: > On Tue, Oct 5, 2010 at 4:32 AM, Sergei Shtylyov <[email protected]> wrote: > > Hello. > > > > On 05-10-2010 0:24, [email protected] wrote: > > > >> From: Victor Rodriguez<[email protected]> > > > >> This patch adds EMAC support for the Hawkboard-L138 system > >> It is under the machine name "omapl138_hawkboard". > >> This system is based on the da850 davinci CPU architecture. > > > >> Signed-off-by: Victor Rodriguez<[email protected]> > >> --- > >> arch/arm/mach-davinci/board-omapl138-hawk.c | 49 > >> +++++++++++++++++++++++++++ > >> 1 files changed, 49 insertions(+), 0 deletions(-) > >> > >> diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c > >> b/arch/arm/mach-davinci/board-omapl138-hawk.c > >> index c472dd8..b22c275 100644 > >> --- a/arch/arm/mach-davinci/board-omapl138-hawk.c > >> +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c > >> @@ -19,6 +19,55 @@ > > > > [...] > > > >> +static int __init omapl138_hawk_config_emac(void) > >> +{ > >> + void __iomem *cfg_chip3_base; > > > > Why not just 'cfgchip3'? > > Because the board file arch/arm/mach-davinci/board-da850-evm.c has the > same name I would like to have coherence because we said taht it is > based on da850 architecture.
I am not sure it really breaks any coherence. Short local variable names are easier to read. CFGCHIP3 is a single register, so _base is redundant anyway. Thanks, Sekhar _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
