On Fri, Oct 08, 2010 at 12:14:33, Vitaly Wool wrote: > On Fri, Oct 8, 2010 at 5:54 AM, Nori, Sekhar <[email protected]> wrote: > > Hi Sergei, > > > > On Thu, Oct 07, 2010 at 20:35:28, Sergei Shtylyov wrote: > > > >> > +static void da830_evm_nor_done(void *data) > >> > +{ > >> > + clk_disable(da830_evm_nor.clk); > >> > + clk_put(da830_evm_nor.clk); > >> > + iounmap(da830_evm_nor.latch.addr); > >> > + release_mem_region(DA8XX_AEMIF_CS3_BASE, PAGE_SIZE); > >> > + iounmap(da830_evm_nor.aemif.addr); > >> > + release_mem_region(DA8XX_AEMIF_CTL_BASE, SZ_32K); > >> > +} > >> > >> Why you've changed this function which was useful also for the error > >> cleanup > >> before? > > > > The issues down below aside, I think goto based error handling > > is clearer to follow. Any objections to using goto based > > error handing per-se? > > What you're saying just doesn't make sense in this context. Whatever > way of error handling is chosen, it first needs to be correct which is > absolutely not the case here.
Yes, agreed. It needs to be correct first. Thanks, Sekhar _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
