Hello. On 08-10-2010 8:54, Nori, Sekhar wrote:
+static void da830_evm_nor_done(void *data) +{ + clk_disable(da830_evm_nor.clk); + clk_put(da830_evm_nor.clk); + iounmap(da830_evm_nor.latch.addr); + release_mem_region(DA8XX_AEMIF_CS3_BASE, PAGE_SIZE); + iounmap(da830_evm_nor.aemif.addr); + release_mem_region(DA8XX_AEMIF_CTL_BASE, SZ_32K); +}
Why you've changed this function which was useful also for the error cleanup before?
The issues down below aside, I think goto based error handling is clearer to follow. Any objections to using goto based error handing per-se?
I think the code was more compact with the old error handling. And anyway, I'm not feeling happy when TI is changing MV's code.
Thanks, Sekhar
WBR, Sergei _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
