Hello.
On 29-11-2010 16:42, Subhasish Ghosh wrote:
Sergei Shtylyov-2 wrote:
I wonder where -2 come from...
Hello.
On 29-11-2010 14:06, Subhasish Ghosh wrote:
The patch adds support for emulated UART controllers
on the programmable realtime unit (PRU) available on OMAPL138.
This defines the system resource requirements such as pin mux,
clock, iomem, interrupt etc and registers the platform device
as per the Linux driver model.
Signed-off-by: Subhasish Ghosh<[email protected]>
[...]
diff --git a/arch/arm/mach-davinci/da850.c
b/arch/arm/mach-davinci/da850.c
index 63916b9..a5eeb4f 100644
--- a/arch/arm/mach-davinci/da850.c
+++ b/arch/arm/mach-davinci/da850.c
[...]
@@ -392,9 +409,13 @@ static struct clk_lookup da850_clks[] = {
/*
* Device specific mux setup
- *
- * soc description mux mode mode mux dbg
- * reg offset mask mode
+ * soc -> DA850
+ * desc -> Pin name, which evaluates to soc##_##desc.
+ * muxreg -> Pin Multiplexing Control n (PINMUXn) Register
number.
+ * mode_offset -> Bit offset in the register PINMUXn.
+ * mode_mask -> Number of bits for Pin Multiplexing Control n.
+ * mux_mode -> Multiplexing mode to set.
+ * dbg -> debug on/off
Why change this at all? And doesn't this intersect with the patch
you've just posted?
You didn't reply...
@@ -557,6 +578,14 @@ const short da850_uart0_pins[] __initdata = {
-1
};
+const short da850_pru_suart_pins[] __initdata = {
+ DA850_AHCLKX, DA850_ACLKX, DA850_AFSX,
+ DA850_AHCLKR, DA850_ACLKR, DA850_AFSR,
+ DA850_AXR_13, DA850_AXR_9, DA850_AXR_7,
+ DA850_AXR_14, DA850_AXR_10, DA850_AXR_8,
Don't these pins belong to McASP?
[SG] -- Yes, To emulate the Soft UART we use the McASP as serializers.
Then this pin list should be in the board file. da850.c already has McASP
pin list (however incomplete).
diff --git a/arch/arm/mach-davinci/devices-da8xx.c
b/arch/arm/mach-davinci/devices-da8xx.c
index 9eec630..3ae9c3e 100644
--- a/arch/arm/mach-davinci/devices-da8xx.c
+++ b/arch/arm/mach-davinci/devices-da8xx.c
[...]
+struct platform_device omapl_pru_suart_device = {
+ .name = "davinci_pru_suart",
+ .id = 1,
Why 1? Is there another device? I don't see it...
You didn't reply...
diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
index 212eb4c..b831ebc 100644
--- a/include/linux/serial_core.h
+++ b/include/linux/serial_core.h
@@ -199,6 +199,9 @@
/* TI OMAP-UART */
#define PORT_OMAP 96
+/* omapl pru uart emulation */
+#define OMAPL_PRU_SUART 97
Shouldn't these constants have PORT_ as a prefix?
I know they should. :-)
diff --git a/include/linux/ti_omapl_pru_suart.h
b/include/linux/ti_omapl_pru_suart.h
new file mode 100644
index 0000000..9179f2c
--- /dev/null
+++ b/include/linux/ti_omapl_pru_suart.h
I think this file belongs with the driver patch. Also, you could place
it into arch/arm/mach-davinci/include/mach...
[SG] -- This header file is included in devices-da8xx.c.
I understand. Nevertheless, the file path suggests that this should be a
part of the driver patch rather than platform patch. If you placed it into
arch/arm/mach-davinci/include/mach/, it would have rightfully belong to the
platform patch...
WBR, Sergei
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
