Hi Kevin, On Sat, Dec 11, 2010 at 06:01:19, Kevin Hilman wrote: > Subhasish Ghosh <[email protected]> writes: > > > The patch adds support for emulated UART controllers > > on the programmable realtime unit (PRU) available on OMAPL138. > > This defines the system resource requirements such as pin mux, > > clock, iomem, interrupt etc and registers the platform device > > as per the Linux driver model. > > > > Signed-off-by: Subhasish Ghosh <[email protected]> > > You might consider setting your git user to use your Mistral address, so > according to git, the author and the sign-off are the same person. > Otherwise, git stats will report your personal address as the author and > your company address as the signoff. > > Also, please Cc [email protected] on all davinci > kernel patches. > > Otherwise, this patch is looking ok (after addressing alignment issue > reported by Sergei.)
Is it OK to merge the platform data before the driver is merged? Thanks, Sekhar > > [...] > > > diff --git a/arch/arm/mach-davinci/include/mach/memory.h > > b/arch/arm/mach-davinci/include/mach/memory.h > > index 22eb97c..d3e48d9 100644 > > --- a/arch/arm/mach-davinci/include/mach/memory.h > > +++ b/arch/arm/mach-davinci/include/mach/memory.h > > @@ -22,6 +22,7 @@ > > > > **************************************************************************/ > > #define DAVINCI_DDR_BASE 0x80000000 > > #define DA8XX_DDR_BASE 0xc0000000 > > +#define DA8XX_SHARED_RAM_BASE 0x80000000 > > please align with previous defines > > > #if defined(CONFIG_ARCH_DAVINCI_DA8XX) && defined(CONFIG_ARCH_DAVINCI_DMx) > > #error Cannot enable DaVinci and DA8XX platforms concurrently > > diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h > > index 212eb4c..407624e 100644 > > --- a/include/linux/serial_core.h > > +++ b/include/linux/serial_core.h > > @@ -199,6 +199,9 @@ > > /* TI OMAP-UART */ > > #define PORT_OMAP 96 > > > > +/* omapl pru uart emulation */ > > +#define PORT_OMAPL_PRU_SUART 97 > > + > > This define is not used in this series. Please add it when you add the > driver which uses it. > > Kevin > _______________________________________________ > Davinci-linux-open-source mailing list > [email protected] > http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source > _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
