Hi Subhasish,
On Wed, Jan 05, 2011 at 14:48:00, S.Ghosh wrote:
> >
> > +static struct clk mcasp_pru_clk = {
> > + .name = "mcasp_pru",
> > + .parent = &pll0_sysclk2,
> > + .lpsc = DA8XX_LPSC1_McASP0,
> > + .gpsc = 1,
> > + .flags = DA850_CLK_ASYNC3,
> > +};
>
>
> There is already a mcasp clock defined. Why not use it instead
> of
> replicating it with a different name? Not doing so will cause a
> mess
> with reference counting.
>
>
>
> [SG] -- This McASP clock is bound with the McASP driver by the device
> ID. This device ID (davinci-mcasp.0) is not
> available to the SUART driver.
You can also look up the clock using con_id if not dev_id. Duplicating
clock structure is definitely wrong.
> Moreover, the McASP driver is written
> specifically for Audio applications. These API's
> are not suitable for our purposes. Hence, to enable the SUART we disable
> the sound sub-system completely and
> configured the McASP in the SUART API's.
Relying on audio driver to be disabled is not a good solution
either. What if there are two McASPs on an SoC and you want to
use one for audio and the other as UART?
I think this is tending toward the need for a common McASP API
which both UART and audio drivers can use. That should take care
of the clock conundrum too.
Thanks,
Sekhar
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
