On Wed, Dec 15, 2010 at 6:31 PM, Sergei Shtylyov <[email protected]>wrote:
> Hello. > > On 03-12-2010 18:11, Subhasish Ghosh wrote: > > The patch adds support for emulated UART controllers >> on the programmable realtime unit (PRU) available on OMAPL138. >> This defines the system resource requirements such as pin mux, >> clock, iomem, interrupt etc and registers the platform device >> as per the Linux driver model. >> > > Signed-off-by: Subhasish Ghosh<[email protected]> >> > [...] > > > diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c >> index 63916b9..85508c2 100644 >> --- a/arch/arm/mach-davinci/da850.c >> +++ b/arch/arm/mach-davinci/da850.c >> @@ -238,6 +238,12 @@ static struct clk tptc2_clk = { >> .flags = ALWAYS_ENABLED, >> }; >> >> +static struct clk pru_clk = { >> + .name = "pruss", >> + .parent = &pll0_sysclk2, >> + .lpsc = DA8XX_LPSC0_DMAX, >> +}; >> + >> > > Shouldn't it be called dmax_clk. And please align the intializer like > it's done for other clocks. [SG] -- Will align these. Will rename DMAX to PRU > > static struct clk uart0_clk = { >> .name = "uart0", >> .parent =&pll0_sysclk2, >> @@ -318,6 +324,14 @@ static struct clk mcasp_clk = { >> .flags = DA850_CLK_ASYNC3, >> }; >> >> +static struct clk mcasp_pru_clk = { >> + .name = "mcasp_pru", >> + .parent = &pll0_sysclk2, >> + .lpsc = DA8XX_LPSC1_McASP0, >> + .gpsc = 1, >> + .flags = DA850_CLK_ASYNC3, >> +}; >> + >> > > We already have McASP clock defined, this is a duplicate one. > [SG] -- This McASP clock is bound with the McASP driver by the device ID. This device ID (davinci-mcasp.0) is not available to the SUART driver. Moreover, the McASP driver is written specifically for Audio applications. These API's are not suitable for our purposes. Hence, to enable the SUART we disable the sound sub-system completely and configured the McASP in the SUART API's. > > static struct clk lcdc_clk = { >> .name = "lcdc", >> .parent =&pll0_sysclk2, >> diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h >> index 212eb4c..407624e 100644 >> --- a/include/linux/serial_core.h >> +++ b/include/linux/serial_core.h >> @@ -199,6 +199,9 @@ >> /* TI OMAP-UART */ >> #define PORT_OMAP 96 >> >> +/* omapl pru uart emulation */ >> +#define PORT_OMAPL_PRU_SUART 97 >> + >> > > This is not used in the patch... > [SG] -- Is now used in the driver. > > WBR, Sergei >
_______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
