On 01/07/2011 09:14 AM, Sergei Shtylyov wrote:
> Hello.
> 
>     Haven't anybody noticed that the EMAC driver in the current DaVinci/DA8xx 
> kernels now uses random MAC addresses instead of the fixed ones.  I suspect 
> the recent changes to the driver made by Cyril Chemparathy... :-)
> 

The emac driver uses the mac_addr stuffed into the pdata, and defaults
to a random mac only if the pdata mac is invalid.  It seems to be doing
the right thing at probe:

        ...
        memcpy(priv->mac_addr, pdata->mac_addr, 6);
        ...
        if (!is_valid_ether_addr(priv->mac_addr)) {
                /* Use random MAC if none passed */
                random_ether_addr(priv->mac_addr);
                printk(KERN_WARNING "%s: using random MAC addr: %pM\n",
                        __func__, priv->mac_addr);
        }
        ...

Could you verify that the pdata mac is correctly populated (from eeprom)
before emac probe happens?

Regards
Cyril.
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to