Michael Williamson <michael.william...@criticallink.com> writes:
> On 1/7/2011 11:03 AM, Steve Chen wrote:
>
>> On Fri, Jan 7, 2011 at 9:50 AM, Cyril Chemparathy <cy...@ti.com> wrote:
>>> On 01/07/2011 09:14 AM, Sergei Shtylyov wrote:
>>>> Hello.
>>>>
>>>> Haven't anybody noticed that the EMAC driver in the current
>>>> DaVinci/DA8xx
>>>> kernels now uses random MAC addresses instead of the fixed ones. I suspect
>>>> the recent changes to the driver made by Cyril Chemparathy... :-)
>>>>
>>>
>>> The emac driver uses the mac_addr stuffed into the pdata, and defaults
>>> to a random mac only if the pdata mac is invalid. It seems to be doing
>>> the right thing at probe:
>>>
>>> ...
>>> memcpy(priv->mac_addr, pdata->mac_addr, 6);
>>> ...
>>> if (!is_valid_ether_addr(priv->mac_addr)) {
>>> /* Use random MAC if none passed */
>>> random_ether_addr(priv->mac_addr);
>>> printk(KERN_WARNING "%s: using random MAC addr: %pM\n",
>>> __func__, priv->mac_addr);
>>> }
>>> ...
>>>
>>> Could you verify that the pdata mac is correctly populated (from eeprom)
>>> before emac probe happens?
>>
>> Cyril,
>>
>> I just saw the same problem on a shiny new AM1808 EVM.
>> pdata->mac_addr are all 0's, so there appears to be a failure reading
>> the MAC address from EEPROM. However, the uImage from PSP 3.20.00.14
>> seems to work. By the way, I used da8xx_omapl_defconfig to build the
>> kernel.
>>
>
>
> It fails because it doesn't attempt to read it at all...
>
> It doesn't appear that the mainline (davinci-linux) has any provisions
> for reading the EMAC address out of the SPI FLASH at initialization for
> the da850 evm. However, the arago/PSP platform file for the da850-evm does.
> So
> it would seem that you have to pass the EMAC addr in via the linux boot args
> from u-Boot (ethaddr=...) if you want to set the MAC address and you're
> using the davinci-linux / mainline tree.
Correct.
At least for da850/EVM, this has never worked with mainline.
Kevin
> I don't see any problems with the MityDSP-L138 / MityARM-1808 platform, but
> that platform initializes the MAC address differently than the evm...
>
> -Mike
> _______________________________________________
> Davinci-linux-open-source mailing list
> Davinci-linux-open-source@linux.davincidsp.com
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
