Hello. On 03-09-2011 0:02, Karicheri, Muralidharan wrote:
Reviewed-by: Sergei Shtylyov<[email protected]>
I haven't reviewed this patch yet. Maybe you mean "Suggested-by:"?
You have reviewed v1 of the patch that has the fix and enhancement as a single patch. You had suggested To move the fix
IIRC, I was only talking about the mask fix. But this patch seems OK.
to a separate patch which I had accepted. Did you suggest without reviewing the code? :) Can I add you as "Reviewed-by" in the next version of the patch?
Yes.
Signed-off-by: Murali Karicheri<[email protected]>
[...]
+ pdctl = __raw_readl(psc_base + PDCTL + 4 * domain); + pdctl |= 0x1; + __raw_writel(pdctl, psc_base + PDCTL + 4 * domain); ptcmd = 1<< domain; __raw_writel(ptcmd, psc_base + PTCMD); @@ -92,9 +92,10 @@ void davinci_psc_config(unsigned int domain, unsignedint ctlr,epcpr = __raw_readl(psc_base + EPCPR); } while ((((epcpr>> domain)& 1) == 0));
Does this work for ARM domain, i.e. does it require an external power supply too?
Not sure. Will someone actively using the DaVinci platforms answer this question?
I may try to verify on my DM6446 if I'll find the time...
- pdctl1 = __raw_readl(psc_base + PDCTL1); - pdctl1 |= 0x100; - __raw_writel(pdctl1, psc_base + PDCTL1); + pdctl = __raw_readl(psc_base + PDCTL + 4 * domain); + pdctl |= 0x100; + __raw_writel(pdctl, psc_base + PDCTL + 4 * domain); + } else { ptcmd = 1<< domain; __raw_writel(ptcmd, psc_base + PTCMD);
WBR, Sergei _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
