Sergei, Thanks for all your investigation work and comments. I will take care of your recent comments against v2 in v3. Looks like the mask is being corrected by a different Patch (ARM: davinci: correct MDSTAT_STATE_MASK) and I can remove the same from my patch.
Sekhar, Do you have a branch I can use to create my patch as it is dependent on "ARM: davinci: correct MDSTAT_STATE_MASK" ? Murali Karicheri Software Design Engineer email: [email protected] >> -----Original Message----- >> From: Sergei Shtylyov [mailto:[email protected]] >> Sent: Wednesday, September 07, 2011 10:55 AM >> To: Karicheri, Muralidharan >> Cc: [email protected]; Nori, Sekhar; Hilman, >> Kevin >> Subject: Re: [PATCH v2 1/2] ARM: davinci - fix incorrect offsets and mask >> usage in psc code >> >> Hello. >> >> On 09/01/2011 10:48 PM, Sergei Shtylyov wrote: >> >> >> There are 5 LSB bits defined in PDSTAT and the code currently uses >> >> a mask of 1 bit to check the status. Also there is PDSTAT and PDCTL >> >> registers defined for ARM domain and DSP domain where as the code >> >> always read the ARM PDSTAT register and DSP PDCTL register. This patch >> >> fixes these issues. >> >> >> Reviewed-by: Sergei Shtylyov<[email protected]> >> >> >> Signed-off-by: Murali Karicheri<[email protected]> >> >> >> arch/arm/mach-davinci/include/mach/psc.h | 2 +- >> >> arch/arm/mach-davinci/psc.c | 19 ++++++++++--------- >> >> 2 files changed, 11 insertions(+), 10 deletions(-) >> >> >> >> diff --git a/arch/arm/mach-davinci/psc.c b/arch/arm/mach-davinci/psc.c >> >> index 1fb6bdf..f157d9c 100644 >> >> --- a/arch/arm/mach-davinci/psc.c >> >> +++ b/arch/arm/mach-davinci/psc.c >> [...] >> >> @@ -92,9 +92,10 @@ void davinci_psc_config(unsigned int domain, >> unsigned int >> >> ctlr, >> >> epcpr = __raw_readl(psc_base + EPCPR); >> >> } while ((((epcpr>> domain)& 1) == 0)); >> >> > Does this work for ARM domain, i.e. does it require an external power >> supply too? >> >> >> - pdctl1 = __raw_readl(psc_base + PDCTL1); >> >> - pdctl1 |= 0x100; >> >> - __raw_writel(pdctl1, psc_base + PDCTL1); >> >> + pdctl = __raw_readl(psc_base + PDCTL + 4 * domain); >> >> + pdctl |= 0x100; >> >> + __raw_writel(pdctl, psc_base + PDCTL + 4 * domain); >> >> + >> >> Didn't notice before: this extra empty line is not needed here. >> >> WBR, Sergei _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
