>> -----Original Message----- >> From: Linus Walleij [mailto:[email protected]] >> Sent: Thursday, September 27, 2012 9:20 AM >> To: Karicheri, Muralidharan >> Cc: [email protected]; [email protected]; [email protected]; >> [email protected]; [email protected]; [email protected]; linux- >> [email protected]; Nori, Sekhar; Hilman, Kevin; [email protected]; >> davinci- >> [email protected]; >> [email protected]; linux- >> [email protected] - Linux developers for Keystone family of devices (May >> contain non- >> TIers); [email protected]; Chemparathy, Cyril >> Subject: [linux-keystone] Re: [PATCH 01/13] clk: davinci - add Main PLL >> clock driver >> >> On Wed, Sep 26, 2012 at 8:07 PM, Murali Karicheri <[email protected]> >> wrote: >> >> > +struct clk_davinci_pll_data { >> > + /* physical addresses set by platform code */ >> > + u32 phy_pllm; >> > + /* if PLL has a prediv register this should be non zero */ >> > + u32 phy_prediv; >> > + /* if PLL has a postdiv register this should be non zero */ >> > + u32 phy_postdiv; >> > + /* mapped addresses. should be initialized by */ >> > + void __iomem *pllm; >> > + void __iomem *prediv; >> > + void __iomem *postdiv; >> > + u32 pllm_mask; >> > + u32 prediv_mask; >> > + u32 postdiv_mask; >> > + u32 num; >> > + /* framework flags */ >> > + u32 flags; >> > + /* pll flags */ >> > + u32 pll_flags; >> > + /* use this value for prediv */ >> > + u32 fixed_prediv; >> > + /* multiply PLLM by this factor. By default most SOC set this to >> > zero >> > + * that translates to a multiplier of 1 and incrementer of 1. >> > + * To override default, set this factor >> > + */ >> > + u32 pllm_multiplier; >> > +}; >> > + >> >> No, that's not what I meant. >> >> I meant like this: >> >> /** >> * struct clk_davinci_pll_data - struct holding the PLL data >> * phy_pllm: physical addresses set by platform code >> * phy_prediv: ... >> (...) >> */ >> struct clk_davinci_pll_data { >> u32 phy_pllm; >> u32 phy_prediv; >> (...) >> }; >> Ok. Will do in the next revision.
Murali Karicheri Software Design Engineer >> Yours, >> Linus Walleij _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
