Hi Prabhakar, On Sunday 03 February 2013 15:43:49 Prabhakar Lad wrote: > On Sat, Feb 2, 2013 at 4:07 AM, Sylwester Nawrocki wrote: > > On 01/29/2013 02:07 PM, Prabhakar Lad wrote: > > [...] > > > >> diff --git a/Documentation/devicetree/bindings/media/i2c/tvp514x.txt > >> b/Documentation/devicetree/bindings/media/i2c/tvp514x.txt > >> new file mode 100644 > >> index 0000000..55d3ffd > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/media/i2c/tvp514x.txt > >> @@ -0,0 +1,38 @@ > >> +* Texas Instruments TVP514x video decoder > >> + > >> +The TVP5146/TVP5146m2/TVP5147/TVP5147m1 device is high quality, > >> +single-chip digital video decoder that digitizes and decodes all popular > >> +baseband analog video formats into digital video component. The tvp514x > >> +decoder supports analog-to-digital (A/D) conversion of component RGB and > >> +YPbPr signals as well as A/D conversion and decoding of NTSC, PAL and > >> +SECAM composite and S-video into component YCbCr. > >> + > >> +Required Properties : > >> +- compatible: Must be "ti,tvp514x-decoder" > > > > There are no significant differences among TVP514* devices as listed > > above, you would like to handle above ? > > > > I'm just wondering if you don't need, for instance, two separate > > compatible properties, e.g. "ti,tvp5146-decoder" and "ti,tvp5147-decoder" > > ? > > There are few differences in init/power sequence tough, I would still > like to have single compatible property "ti,tvp514x-decoder", If you feel we > need separate property I will change it please let me know on this.
If there's any difference between the chips that need to be handled in the driver, using two compatible properties is a good practice. Your driver will then be able to easily differentiate between the two chips, and there's no real drawback in doing so. -- Regards, Laurent Pinchart _______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
