To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=18907
User fs changed the following:
What |Old value |New value
================================================================================
Assigned to|fs |dyf
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Mon Jul 16 08:38:31 +0000
2007 -------
okay, patch looks much better now :)
Two tiny little wishes, though:
- with setCreateStyleAction, you introduce a new method, which works fine, but
is prone to future errors. That is, if somebody later finds this method
useful, and
uses it for own purposes, the dialog/page might be left inconsistent: Consider
somebody calling setCreateStyleAction( WIZARD_DEF ) - this would *not*
be reflected in the dialog's CreateStyle
In other words, I think setCreateStyleAction is missing a call to
m_pParent->setCreateStyleAction.
Speaking strictly, it is also missing a call to SetAppendDataRadio
respectively
RadioChangeHdl - those methods would also ensure the state of the remaining
controls on the page fits the state of the check boxes.
- Please clean you patch from unnecessary whitespace changes (there are a
few chunks which contain only changes in whitespaces), and unnecessary
changes such as the new-but-commented-out line 140 in TableCopyHelper.hxx
Thanks.
Those two things addressed, I am willing to commit the patch.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
