To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=18907





------- Additional comments from [EMAIL PROTECTED] Mon Jul 23 06:36:23 +0000 
2007 -------
well, my idea was the current code works fine, but it is easy to break it in
future. That is, we're talking about robustness of code here.

Consider the example I mentioned: if tomorrow, somebody does a
|setCreateStyleAction( WIZARD_DEF )| at the page, then he needs to also do a
|setCreateStyle| at the dialog. (Sorry, I mistyped this in my previous comment,
I wrongly wrote "m_pParent->setCreateStyleAction" instead of
"m_pParent->setCreateStyle".).

This coupling is prone to errors. Your new code would be more robust if the
implementation of |setCreateStyleAction| *atuomatically* would call
|setCreateStyle| at the dialog.

Okay, be it. If you would please provide me the complete actual patch, I'm
willing to check it in.

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to