Tag: cws_src680_qiq User: fs Date: 06/06/16 06:14:30 Modified: /dba/dbaccess/source/core/dataaccess/ ComponentDefinition.cxx
Log: ChildHelper_Impl did not work as expected (the parent of m_pColumns are we ourself, and we die earlier than the column descriptor which we put into m_pImpl File Changes: Directory: /dba/dbaccess/source/core/dataaccess/ ================================================ File [changed]: ComponentDefinition.cxx Url: http://dba.openoffice.org/source/browse/dba/dbaccess/source/core/dataaccess/ComponentDefinition.cxx?r1=1.5.118.1&r2=1.5.118.2 Delta lines: +2 -20 -------------------- --- ComponentDefinition.cxx 16 Jun 2006 11:47:38 -0000 1.5.118.1 +++ ComponentDefinition.cxx 16 Jun 2006 13:14:27 -0000 1.5.118.2 @@ -4,9 +4,9 @@ * * $RCSfile: ComponentDefinition.cxx,v $ * - * $Revision: 1.5.118.1 $ + * $Revision: 1.5.118.2 $ * - * last change: $Author: fs $ $Date: 2006/06/16 11:47:38 $ + * last change: $Author: fs $ $Date: 2006/06/16 13:14:27 $ * * The Contents of this file are made available subject to * the terms of GNU Lesser General Public License Version 2.1. @@ -61,9 +61,6 @@ #ifndef _DBACORE_DEFINITIONCOLUMN_HXX_ #include "definitioncolumn.hxx" #endif -#ifndef DBA_COREDATAACCESS_CHILDHELPER_HXX -#include "ChildHelper.hxx" -#endif using namespace ::com::sun::star::uno; @@ -265,21 +262,6 @@ Reference<XPropertySet> xColDesc = new OTableColumnDescriptor(); ::comphelper::copyProperties( _rxSourceDescriptor, xColDesc ); getDefinition().insert( sName, xColDesc ); - - Reference< XChild > xChild( xColDesc, UNO_QUERY ); - if ( xChild.is() ) - { - // TODO: what's this? - // it tells the xColDesc that its parent is a OChildHelper_Impl, with the only functionality - // that this parent is a XChild itself, which forwards its set/getParent to the m_pColumns instance. - // The reason seems to be that this way, it's ensured that m_pColumns is not held hard by xColDesc, - // but shouldn't this be fixed in the xColDesc implementation? - // And: is it *correct* that the column definition gets m_pColumns as parent? Or is this just a hack, - // so that when in the implementation of the column definition, it's possible to walk up the parent - // hierarchy, find a data source, and modify it? - Reference< XChild > xParent = new OChildHelper_Impl( static_cast< XChild* >( static_cast< TXChild* >( m_pColumns.get() ) ) ); - xChild->setParent( xParent ); - } notifyDataSourceModified(); } --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
