Tag: cws_src680_qiq User: fs Date: 06/06/16 06:19:34 Modified: /dba/dbaccess/source/core/dataaccess/ ComponentDefinition.cxx
Log: added explanation for the previous change File Changes: Directory: /dba/dbaccess/source/core/dataaccess/ ================================================ File [changed]: ComponentDefinition.cxx Url: http://dba.openoffice.org/source/browse/dba/dbaccess/source/core/dataaccess/ComponentDefinition.cxx?r1=1.5.118.2&r2=1.5.118.3 Delta lines: +11 -2 -------------------- --- ComponentDefinition.cxx 16 Jun 2006 13:14:27 -0000 1.5.118.2 +++ ComponentDefinition.cxx 16 Jun 2006 13:19:31 -0000 1.5.118.3 @@ -4,9 +4,9 @@ * * $RCSfile: ComponentDefinition.cxx,v $ * - * $Revision: 1.5.118.2 $ + * $Revision: 1.5.118.3 $ * - * last change: $Author: fs $ $Date: 2006/06/16 13:14:27 $ + * last change: $Author: fs $ $Date: 2006/06/16 13:19:31 $ * * The Contents of this file are made available subject to * the terms of GNU Lesser General Public License Version 2.1. @@ -262,6 +262,15 @@ Reference<XPropertySet> xColDesc = new OTableColumnDescriptor(); ::comphelper::copyProperties( _rxSourceDescriptor, xColDesc ); getDefinition().insert( sName, xColDesc ); + + // formerly, here was a setParent at the xColDesc. The parent used was an adapter (ChildHelper_Impl) + // which held another XChild weak, and forwarded all getParent requests to this other XChild. + // m_pColumns was used for this. This was nonsense, since m_pColumns dies when our instance dies, + // but xColDesc will live longer than this. So effectively, the setParent call was pretty useless. + // + // The intention for this parenting was that the column descriptor is able to find the data source, + // by traveling up the parent hierachy until there's an XDataSource. This didn't work (which + // for instance causes #i65023#). We need another way to properly ensure this. notifyDataSourceModified(); } --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
