2010/9/14 Jens Rehsack <rehs...@googlemail.com>: > 2010/9/14 H.Merijn Brand via RT <bug-dbd-...@rt.cpan.org>: >> <URL: https://rt.cpan.org/Ticket/Display.html?id=61168 > >> >> The "problem" is two-fold. Using the most recent versions of DBI, >> SQL::Statement, Text::CSV_XS and DBD::CSV, the problem was that the >> csv_in and csv_out objects for Text::CSV_XS were created before they >> saw the sep_char attribute change, so it never got to the parser. > > That's what I tried to explain at the begin of July - but I know, Belgium Perl > Workshop and holiday preparation... > >> I've patched the most recent version (get it from git to test). > > The last paragraph of > http://search.cpan.org/~timb/DBI-1.613_94/lib/DBD/File/HowTo.pod#User_comfort > should you guide how it's intended.
Ok, I understood your desire - but your patch doesn't catch all the backward compatibility you typically want - see (and apply) 0001-add-test-case-for-rt61168.patch first. As we have no reason this time to run DBD::CSV-0.31 with DBI<1.614, I didn't patch the set_table_meta_attr method but added the real fix using newly introduced table_meta_attr_changed (0002-fix-rt61168.patch - requires patch-DBI-rt61168). If any of the DBI developers wants to review patch-DBI-rt61168 before I commit, please do. >> Note that you cannot pass it as "sep_char", but have to add the DBD >> prefix and use "csv_sep_char". > > The documentation should be updated in this case. > >> $ cat sandbox/rt61168.pl > [...] >> Jens, note the wrong setting for f_fqbn > > I'd say this is intended by the file2table implementation, but I > can't figure out why. We should probably take a close look > to this function together :( > > Stop timbo releasing 1.614 before we figured out this. Probably we > should add a nice test for it to t/51dbm_file.t ... This should be the next task and all apologies to David "theory" Wheeler for delaying the release. /Jens
0001-add-test-case-for-rt61168.patch
Description: Binary data
patch-DBI-rt61168
Description: Binary data
0002-fix-rt61168.patch
Description: Binary data
