On Thu, 16 Sep 2010 09:43:05 +0200, Jens Rehsack <rehs...@googlemail.com> wrote:
> 2010/9/16 H.Merijn Brand <h.m.br...@xs4all.nl>: > > On Wed, 15 Sep 2010 23:51:40 +0200, Jens Rehsack > > <rehs...@googlemail.com> wrote: > > > >> Ok, I understood your desire - but your patch doesn't catch all the > >> backward > >> compatibility you typically want - see (and apply) > >> 0001-add-test-case-for-rt61168.patch > >> first. > >> > >> As we have no reason this time to run DBD::CSV-0.31 with DBI<1.614, I > >> didn't patch > >> the set_table_meta_attr method but added the real fix using newly > >> introduced > >> table_meta_attr_changed (0002-fix-rt61168.patch - requires > >> patch-DBI-rt61168). > >> > >> If any of the DBI developers wants to review patch-DBI-rt61168 before I > >> commit, > >> please do. > > > > Applied, committed, pulled, tidied, tested, committed, applied, > > committed, tested, pushed. > > A prerequisite bump to DBI 1.614 for DBD::CSV 0.31 will be required (I > didn't send a patch for that). If you would have pull'ed, you'd have seen that was already done :) > I've also now committed (and for git users pushed) a patch for > lib/DBD/File.pm (untidied) > which manages late f_file meta attribute set. From my point of view > this commit makes DBI 1.614 ready to ship (after you've tidied). +1 I'll release DBD::CSV shortly after -- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using 5.00307 through 5.12 and porting perl5.13.x on HP-UX 10.20, 11.00, 11.11, 11.23, and 11.31, OpenSuSE 10.3, 11.0, and 11.1, AIX 5.2 and 5.3. http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
