On 27 Nov 2001, David Wheeler wrote:

> Date: 27 Nov 2001 09:52:12 -0800
> From: David Wheeler <[EMAIL PROTECTED]>
> To: Rudy Lippan <[EMAIL PROTECTED]>
> Cc: [EMAIL PROTECTED], [EMAIL PROTECTED]
> Subject: Re: DBD::Pg Patch Submission
> 
> On Tue, 2001-11-27 at 09:10, Rudy Lippan wrote:
> >  +       return $str if $data_type && $no_escape[$data_type];
> >  +       $str =~ s/(['\\\0])/$esc{$&}/g;
> >                   ^^      ^^     ^^^^^
> > Umm.. Did you want that to be $1 instead of $&?
> 
> No, but now that I think about it, I could probably eliminate the
> parentheses:
> 

Why are you using $& over $1?  $& slows down ALL regexes in the
program? 


Later,

Rudy 


>  +       return $str if $data_type && $no_escape[$data_type];
>  +       $str =~ s/['\\\0]/$esc{$&}/g;
> 
> David
> 
> -- 
> David Wheeler                                     AIM: dwTheory
> [EMAIL PROTECTED]                                 ICQ: 15726394
>                                                Yahoo!: dew7e
>                                                Jabber: [EMAIL PROTECTED]
> 
> 


Reply via email to