Thanks. I had meant to redo that using $Config::Config{path_sep}.
In other words, only complain about colons in the cwd if path_sep is ':'.
Could you try that for me and send me an updated patch?
Tim.
On Mon, Sep 08, 2003 at 04:18:55PM +0100, Steve Hay wrote:
> Hi,
>
> I've just installed DBI-1.38 on Windows XP using MSVC++ 6.0 and got this
> warning three times over from the "perl Makefile.PL" step:
>
> *** Warning: Colons in the current directory path (C:/Temp/DBI-1.38) may
> cause problems
>
> Since you're unlikely to have a path without colons on Win32 (unless
> you're building in a UNC share or something daft!), the attached patch
> to suppress those warnings seems sensible. (I've included the osnames
> "dos" and "os2" in the patch too. DOS certainly has paths like MSWin32
> does; I'm not completely sure about OS/2.)
>
> Cheers,
> - Steve
> --- DBD.pm.orig 2003-08-20 01:15:42.000000000 +0100
> +++ DBD.pm 2003-09-08 16:09:30.000000000 +0100
> @@ -3562,7 +3562,7 @@
> sub _cwd_check {
> my $cwd = cwd();
> return unless $cwd =~ m/:/;
> - return if $^O eq 'darwin';
> + return if $^O =~ /^(?:darwin|MSWin32|dos|os2)$/io;
> warn "*** Warning: Colons in the current directory path ($cwd) may cause
> problems\a\n";
> sleep 2;
> }
