On 28-Jul-2006 John Scoles wrote: > > ----- Original Message ----- > From: "Fox, Michael" <[EMAIL PROTECTED]> > To: <dbi-users@perl.org> > Sent: Thursday, July 27, 2006 11:00 PM > Subject: RE: ANNOUNCE: DBD:Oracle 1.18 > > >> >> Sorry I did not get a chance to test this before the release, but I have >> had >> a couple of problems building the new version, and any advice would be >> welcome. So far I have: >> > No problem > >> Platform: Tru64 Unix V5.1 2650 alpha, native compiler >> Oracle: 8.1.7 >> Perl: 5.8.7 >> >> Problem 1: cc: Error: Oracle.xs, line 269: In this statement, "startp" is >> not declared. (undeclared) >> ME: startp declaration has been commented out in this version, so I >> uncommented it to continue > > This is what I was afraid of. I commented it out because it was causeing my > compilers (win vc++ and lunix gcc) to throw a warning like 'startp is > declared but never used'. > Well a warning in one compiler is better than and error in an other so I > will fix that in trunk but put a comment why it is needed.
Hang on. The problem is because startp is only used like this: #if !defined(ORA_OCI_8) && defined(OCI_HTYPE_DIRPATH_FN_CTX) .. .. #else OCILobGetLength_log_stat(imp_dbh->svchp, imp_dbh->errhp, locator, &startp, #endif but it is not declared conditionally. You make think warnings are better than errors but if I see a warning when I compile something it immediately makes suspicious and it is sometimes justified. Martin -- Martin J. Evans Easysoft Ltd, UK http://www.easysoft.com
