On Fri, May 01, 2015 at 06:34:58PM +0200, jl...@escomposlinux.org wrote: > Hi Tim,
Hi! > I have got as a May a assignment your module DBI. Congratulations :) > In Neil's message he sugested 3 areas for the pull request: > """ > Notes on your distribution: > > * It has a file 'test.pl' in the top directory. > The modern convention is for all tests to live in a 't/' directory. test.pl is more of a manual testing tool - you'll see it has a bunch of options for command line use. It could simply be renamed to tester.pl :) > * The distribution has CPAN Testers failures, so you could look at those: > http://www.cpantesters.org/distro/D/DBI.html I find http://matrix.cpantesters.org/?dist=DBI+1.633 easier to read. Most of the failures are for obscure systems like mirbsd and dragonfly that, I'd guess, you don't have access to. So those would be tricky. If you have access to Windows then investigating those failures might be useful. > * The distribution has CPANTS warnings - check out its page for details: > http://cpants.cpanauthors.org/dist/DBI Addressing the 'use strict' and 'use warnings' metrics seems reasonable at first sight. (I'm less keen on 'consistent version' though.) Adding a LICENSE file would also be good. > I would like to take the first suggestion first but do you like me to look > on other issues? Feel free to scan the issues in RT and see if any appeal. > Must I test the changes in all perl releases since 5.008 or using the ones > available on perlbrew will be enough? perlbrew versions are fine. > Thanks for your time Thank you! Feel free to email or ping me or others on IRC. Good luck! Tim.
