On Tue, 28 Oct 2008 13:26:52 +0100 BUCHMULLER Norbert
<[EMAIL PROTECTED]> wrote:

Sorry, I sent it too early by accident.

> > > Regarding 1.: I think that should be OK.
> > 
> > These tests go into t/76retrieve.t (new file)
> 
> Done (see the new patch).

When I started to create the patch, I found that this test should go
tot/88_result_set_column.t indeed, as it operates on resultset columns
like the other tests in that file. Just it has to be reformulated like the
other tests for '+select'/'+as' in that file. (Ignore the '->first' part
for now - that's unrelated to it.)


> The other approach that came to my mind is to change
> 
>  defined($psrs->get_column('...'))
> 
> to
> 
>  defined($psrs->get_column('...')->first)

Oops, here I meant:

 defined($psrs->get_column('...')->next)


PS: Sorry for the above mistake I made (ie. sending the mail too early).

norbi

_______________________________________________
List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class
IRC: irc.perl.org#dbix-class
SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/
Searchable Archive: http://www.grokbase.com/group/[email protected]

Reply via email to