Il giorno sab, 13/06/2009 alle 22.09 -0400, Jonathan Pryor ha scritto: > On Sat, 2009-06-13 at 16:57 +0200, Federico Di Gregorio wrote: > > This one should be clean. Ok to commit? > > It'll be OK to commit once you add some tests for it. :-)
In adding the tests I found another series of problems:
1. PgsqlVendor should be renamed PostgreSqlVendor or using
DataContext constructors with a connection string won't work.
2. I can't do the changes (renaming the files) myself because I am
using MonoDevelop and that requires some changes to the project
(.csproj) files. Before committing such changes we should test
they still work with VS.
So, right now my last version of the patch tries to fix the problem
without breaking compatibility by adding to PgsqlVendor.cs an empty
class named PostgreSqlVendore that inherits on PgsqlVendor. Is this ok
until we agree on the name changes? (I suppose all classes/files should
be renamed from PgsqlXXX to PostgreSqlXXX or vice-versa.)
I also added the following test to DbLinq_tests/DataContextTests.cs.
Should I mark it [Explicit] to make sure it is not executed on other
databases then PostgreSQL?
[Test]
public void Ctor_ConnectionString_ExtraParameters_Munging()
{
DataContext ctx = new
DataContext("DbLinqProvider=PostgreSql;DbLinqConnectionType=Npgsql.NpgsqlConnection,Npgsql");
Assert.AreEqual(-1,
ctx.Connection.ConnectionString.IndexOf("DbLinqProvider"));
Assert.AreEqual(-1,
ctx.Connection.ConnectionString.IndexOf("DbLinqConnectionType"));
}
Ok to commit?
federico
--
Federico Di Gregorio http://people.initd.org/fog
Debian GNU/Linux Developer [email protected]
INIT.D Developer [email protected]
Best friends are often failed lovers. -- Me
signature.asc
Description: Questa รจ una parte del messaggio firmata digitalmente
