On Mon, 2009-06-15 at 10:13 +0200, Federico Di Gregorio wrote:
> So, right now my last version of the patch tries to fix the problem
> without breaking compatibility by adding to PgsqlVendor.cs an empty
> class named PostgreSqlVendore that inherits on PgsqlVendor.
I'd prefer doing the opposite - rename PgsqlVendor to PostgreSqlVendor
and create a new PgsqlVendor type which inherits from PostgreSqlVendor.
> Is this ok
> until we agree on the name changes? (I suppose all classes/files should
> be renamed from PgsqlXXX to PostgreSqlXXX or vice-versa.)
Yes.
> I also added the following test to DbLinq_tests/DataContextTests.cs.
> Should I mark it [Explicit] to make sure it is not executed on other
> databases then PostgreSQL?
I think it should always be executed. The test doesn't open a
connection to the database, it just creates an NpgsqlConnection
instance, and since we bundle Npgsql.dll with DbLinq this should cause
no problems.
> [Test]
> public void Ctor_ConnectionString_ExtraParameters_Munging()
> {
> DataContext ctx = new
> DataContext("DbLinqProvider=PostgreSql;DbLinqConnectionType=Npgsql.NpgsqlConnection,Npgsql");
> Assert.AreEqual(-1,
> ctx.Connection.ConnectionString.IndexOf("DbLinqProvider"));
> Assert.AreEqual(-1,
> ctx.Connection.ConnectionString.IndexOf("DbLinqConnectionType"));
> }
>
> Ok to commit?
Yes.
- Jon
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"DbLinq" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/dblinq?hl=en
-~----------~----~----~----~------~----~------~--~---
