One question about the EP1-error-handling.patch: Why do some classes use
_PascalCase (e.g. DbLinq.Mssql.Example) while others use _camelCase
(PosgtreSQL, SQLite).

Shouldn't these be _consistent_? :-)  (Or are we not using DbMetal to
generate all of these types?  For that matter, iirc we don't even have a
SchemaLoader implementation for Microsoft SQL Server, meaning we can't
even point our DbMetal at SQL Server to generate sources.)

For that matter, we seem to have broken DbMetal.  This used to work
(when run from the tests directory):

        ..\build.dbg\DbMetal.exe /namespace:nwind/code:Northwind.cs
         /pluralize "/conn:Data Source=Northwind.db3" /provider:Sqlite

I know this because I wrote it down in the r1075 commit message. :-)

Now, however, it fails:

        DbMetal failed:System.Collections.Generic.KeyNotFoundException: The 
given key was not present in the dictionary.
           at System.ThrowHelper.ThrowKeyNotFoundException()
           at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
           at DbLinq.Vendor.Implementation.SchemaLoader.LoadForeignKey(Database 
schema, Table table, String columnName, String tableName, String tableSchema, 
String ref
        erencedColumnName, String referencedTableName, String 
referencedTableSchema, String constraintName, NameFormat nameFormat, Names 
names) in 
Z:\Development\mono-HEAD\dblinq2007\src\DbLinq\Vendor\Implementation\SchemaLoader.ForeignKey.cs:line
 0
           at DbLinq.Sqlite.SqliteSchemaLoader.LoadConstraints(Database schema, 
SchemaName schemaName, IDbConnection conn, NameFormat nameFormat, Names names) 
in 
Z:\Development\mono-HEAD\dblinq2007\src\DbLinq.Sqlite\SqliteSchemaLoader.cs:line
 84
           at DbLinq.Vendor.Implementation.SchemaLoader.Load(String 
databaseName, INameAliases nameAliases, NameFormat nameFormat, Boolean 
loadStoredProcedures, String contextNamespace, String entityNamespace) in 
Z:\Development\mono-HEAD\dblinq2007\src\DbLinq\Vendor\Implementation\SchemaLoader.cs:line
 123
           at DbMetal.Generator.Implementation.Processor.ReadSchema(Parameters 
parameters, ISchemaLoader& schemaLoader) in 
Z:\Development\mono-HEAD\dblinq2007\src\DbMetal\Generator\Implementation\Processor.cs:line
 218
           at 
DbMetal.Generator.Implementation.Processor.ProcessSchema(Parameters parameters) 
in 
Z:\Development\mono-HEAD\dblinq2007\src\DbMetal\Generator\Implementation\Processor.cs:line
 112

Something broke, somewhere.  :-(

 - Jon

On Fri, 2009-10-23 at 14:47 +1100, Evgeny Potashnik wrote:
> Hi,
> 
> I'd like to contribute a couple of minor patches. The first contains
> the one-character fix to the Postgres NorthwindCustom.cs which reduces
> the number of failing test from >200 to 85 and some minor
> error-handling improvements that I made while investigating while
> tests are failing (so you might get a meaningful error message instead
> of NullReferenceException). The second fixes two problems with the
> logging which caused the logged expression tree to be incomplete - a
> NullReferenceException and not flushing the TextWriter at the end.
> 
> Regards,
> 
> Evgeny Potashnik
> 
> > 


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"DbLinq" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/dblinq?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to