On Mon, 2009-10-26 at 09:53 +1100, Evgeny Potashnik wrote: > Thanks for reviewing my patch.
Sorry for the delay. The short version is that you may commit this patch. The long version is that I'm learning that patch(1) hates my guts. Specifically, patch(1) under Linux often (always so far!) rejects patches because the "Index:", @@...@@, ^+++, and ^--- lines end with \r \n, and the \r causes an immediate rejection. I can manually fix this, but it's annoying. Alternatively, I can use patch(1) under Cygwin, but that results in changing the EOL character on the entire file. Result: instead of small changes, the entire file is changed. FAIL. I'm wondering what people who regularly deal with open-source software under Windows do (aside from avoid all DOS-formatted files). That aside, the patch looks fine, and if you say it doesn't regress any tests then that's fine with me. :-) Thanks, - Jon --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "DbLinq" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/dblinq?hl=en -~----------~----~----~----~------~----~------~--~---
