On Sat, 2009-11-07 at 14:21 +0100, Emanuele Aina wrote:
> Reworked patch attached.

Commit, but first:

  - Processor.cs should follow normal brace conventions, so { should go 
    on a new line (`if (parameters.Help) {...`).
  - Processor.cs should catch Exception, not just OptionException
    (as Options will pass-through any intermediate exceptions unwrapped,
    e.g. string->int conversions or exceptions thrown from the Action
    callbacks).

You'll likely also need to rebase against trunk, as I recently changed
DbMetal to generate both INotifyPropertyChanged and
INotifyPropertyChanging interfaces, and this will impact your patch
(e.g. the Parameters.cs @@ -248... @@ block) and Option documentation
(entityInterfaces option).

Once you've made those changes, you can commit w/o further review.

Thanks!
 - Jon



--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"DbLinq" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/dblinq?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to