On Sat, 2009-11-07 at 14:27 +0100, Emanuele Aina wrote: > Jonathan Pryor precisò: > > Ooh, one other comment that just occurred to me: you shouldn't use > > Parameters.GetArray() for e.g. Parameters.EntityImplementedInterfaces, > > as it would be useful for the user to be able to specify the option > > multiple times, e.g. > > > > DbMetal --entityInterfaces=IFoo --entityInterfaces=IBar > > My plan was to apply such semantic changes in a different patch, but if > you prefer to have them all together I'll resend the patch.
Good point. Do them as separate patches. > Maybe should I remove the comma-separated-list options altogether with > the mechanism you described? > > As in 'DbMetal --entityInterface=IFoo --entityInterface=IBar' instead of > 'DbMetal --entityInterfaces=IFoo,IBar'? I'm open to other opinions, but I prefer having them as separate values than as comma-separated values. That said, mcs seems to do both: have a *singular* option, which can be specified multiple times, but can ALSO take a comma-separated list of values, e.g. 'csc -d:foo -d:bar -d:baz,qux'. Ditto with -lib. So I would suggest following suit: use singular option names, e.g. --entityInterface instead of --entityInterfaces, but allow multiple comma-separated values to be used. I'd also suggest providing shorter option alias, e.g. -i for entityInterface, -b for entityBase, -ea for entityAttribute, -ma for memberAttribute. Then again, perhaps not -- longer names can be more readable. Thanks, - Jon --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "DbLinq" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/dblinq?hl=en -~----------~----~----~----~------~----~------~--~---
