Serious, yes, but show stopper, no... that mail is delivered and is not lost.

Definitely my fault, though. That looks exactly like a diff I had between two
versions of main.c I had been working on when I realized that I'd duplicated
my own work into two separate trees. *oops*.

One of the main reasons for using getopt() is to avoid rigid argument
orderings. There was *supposed* to be an extra test to see if the variable
delivery_to_mailbox is non-null, and if so, to loop through the dsnusers list
and set the destination mailbox correctly.

There's another fix I'd like to make, which is both to document the '-f
return_path' argument and to change it to be '-r return_path' because
elsewhere there is an argument '-f config_file' -- that should be made into a
universal argument for all of the main()'s.

Aaron


""Matthew T. O'Connor"" <[email protected]> said:

> 
> I'm seeing the same thing here....  
> 
> 
> On Sat, 2004-03-20 at 07:48, Paul J Stevens wrote:
> > Hi all,
> > 
> > I'm busy testing rc4, and I think I found a show-stopper.
> > 
> > Looks like delivery to mailboxes doesn't work. All mail gets delivered
> > to INBOX.
> > 
> > When I do 'cat testmail|/usr/sbin/dbmail-smtp -m Trash -u pablo' mail 
> > gets delivered to INBOX.
> > 
> > As far as I can tell, deliver_to_mailbox is assigned in main.c, but 
> > never used.
> > 
> > A simple/dirty patch that solves the problem but makes dbmail-smtp 
> > dependant on the order of options (like 1.2):
> > 
> > diff -urNad /usr/src/dbmail/dbmail-2.0/dbmail-2.1/main.c dbmail-2.1/main.c
> > --- /usr/src/dbmail/dbmail-2.0/dbmail-2.1/main.c        2004-03-20 
> > 13:42:03.000000000 +0100
> > +++ dbmail-2.1/main.c   2004-03-20 13:43:19.000000000 +0100
> > @@ -165,6 +165,9 @@
> >  
> > 
> >                          dsnuser_init(&dsnuser);
> >                          dsnuser.address = strdup(optarg);
> > +                        if (deliver_to_mailbox) {
> > +                               dsnuser.mailbox = 
> > strdup(deliver_to_mailbox);
> > +                       }
> >  
> > 
> >                          /* Add argument onto the users list. */
> >                          if (list_nodeadd
> > 
> 
> _______________________________________________
> Dbmail-dev mailing list
> [email protected]
> http://twister.fastxs.net/mailman/listinfo/dbmail-dev
> 



-- 



Reply via email to