Ok, try this out. Adds all of the arguments to the usage message, adds the extra loop for the mailbox selection, adds config file selection, and changes the ill-chosen argument -f, for "from" to -r, "return" since -f is used elsewhere for the config file.
Ilja: I'm not on my devel box for a few days, so if the patch works out,
please commit it to CVS!
Aaron
Paul J Stevens <[EMAIL PROTECTED]> said:
>
> Aaron Stone wrote:
>
> >Serious, yes, but show stopper, no... that mail is delivered and is not lost.
> >
> >
> I would still call it a show stopper in terms of final release, because
> it would cause both users and system administrators who rely on this
> feature major headaches when suddenly inboxes are swamped by messages
> normally filtered out into other folders.
>
> I've been thinking about what kind of QA we can offer in the future. Is
> something like unit-testing feasible ? I come from a python background,
> and we never build stuff anymore without a test-framework. Also, an
> expect(1) based test setup for the daemons would also be a boon, I think.
>
> I'm planning to test the ldap-auth module over the next week. Has anyone
> done so already? If so, what is the status of:
> - ldap account creation and maintenance using dbmail-adduser.
> - authentication and delivery.
> Especially the latter should be well testing imo before release. Account
> maintenance can be done through other means, but without authentication
> and delivery I won't even bother building packages with ldap enabled.
>
> Also, thunderbird now performs adequately with Ilja's acl fix. But
> connections are still quite flakey. I still see massive numbers of EPIPE
> errors in the syslog. A typical sequence reads:
>
> Mar 20 15:42:50 tsuki dbmail/imap4d[32195]: PerformChildTask(): incoming
> connection from [172.16.3.2]
> Mar 20 15:42:50 tsuki dbmail/imap4d[32195]: COMMAND: [1 authenticate login]
> Mar 20 15:42:51 tsuki dbmail/imap4d[32195]: IMAPD [PID 32195]: user (id
> 5, name someuser) login accepted @ 2004-03-20 15:42:51^M
> Mar 20 15:42:51 tsuki dbmail/imap4d[32195]: COMMAND: [2 STATUS
> "somefolder" (UIDNEXT MESSAGES UNSEEN RECENT)]
> Mar 20 15:42:51 tsuki dbmail/imap4d[32195]: COMMAND: [2]
> Mar 20 15:42:51 tsuki dbmail/imap4d[32195]: IMAPClientHandler(): error
> [Broken pipe] on write-stream
>
> And this is repeated over and over for each mailbox checked. And it
> means thunderbird is unable to check all folders for unread email with
> option: user_pref("mail.check_all_imap_folders_for_new", true);
>
> And finally, I've done some testing on shared folders. When I set the
> ACL lookup and read flags, but not the seen flag (which is a use-case I
> use as a selling point for dbmail; office-manager sets read flags on
> incoming mail only after an issue has been assigned to a co-worker,
> while the co-workers can only read and download mail), thunderbird
> becomes very confused.
>
> >One of the main reasons for using getopt() is to avoid rigid argument
> >orderings. There was *supposed* to be an extra test to see if the variable
> >delivery_to_mailbox is non-null, and if so, to loop through the dsnusers list
> >and set the destination mailbox correctly.
> >
> >
> You mean to say 'dbmail-smtp -m somefolder -u joe -u jane' would then be
> valid ?
>
> >There's another fix I'd like to make, which is both to document the '-f
> >return_path' argument and to change it to be '-r return_path' because
> >elsewhere there is an argument '-f config_file' -- that should be made into a
> >universal argument for all of the main()'s.
> >
> >Aaron
> >
> >
> >""Matthew T. O'Connor"" <[email protected]> said:
> >
> >
> >
> >>I'm seeing the same thing here....
> >>
> >>
> >>On Sat, 2004-03-20 at 07:48, Paul J Stevens wrote:
> >>
> >>
> >>>Hi all,
> >>>
> >>>I'm busy testing rc4, and I think I found a show-stopper.
> >>>
> >>>Looks like delivery to mailboxes doesn't work. All mail gets delivered
> >>>to INBOX.
> >>>
> >>>When I do 'cat testmail|/usr/sbin/dbmail-smtp -m Trash -u pablo' mail
> >>>gets delivered to INBOX.
> >>>
> >>>As far as I can tell, deliver_to_mailbox is assigned in main.c, but
> >>>never used.
> >>>
> >>>A simple/dirty patch that solves the problem but makes dbmail-smtp
> >>>dependant on the order of options (like 1.2):
> >>>
> >>>diff -urNad /usr/src/dbmail/dbmail-2.0/dbmail-2.1/main.c dbmail-2.1/main.c
> >>>--- /usr/src/dbmail/dbmail-2.0/dbmail-2.1/main.c 2004-03-20
> >>>13:42:03.000000000 +0100
> >>>+++ dbmail-2.1/main.c 2004-03-20 13:43:19.000000000 +0100
> >>>@@ -165,6 +165,9 @@
> >>>
> >>>
> >>> dsnuser_init(&dsnuser);
> >>> dsnuser.address = strdup(optarg);
> >>>+ if (deliver_to_mailbox) {
> >>>+ dsnuser.mailbox =
> >>>strdup(deliver_to_mailbox);
> >>>+ }
> >>>
> >>>
> >>> /* Add argument onto the users list. */
> >>> if (list_nodeadd
> >>>
> >>>
> >>>
> >>_______________________________________________
> >>Dbmail-dev mailing list
> >>[email protected]
> >>http://twister.fastxs.net/mailman/listinfo/dbmail-dev
> >>
> >>
> >>
> >
> >
> >
> >
> >
>
> _______________________________________________
> Dbmail-dev mailing list
> [email protected]
> http://twister.fastxs.net/mailman/listinfo/dbmail-dev
>
--
mainfix.patch
Description: Binary data
