On 7 August 2013 17:25, Hady elsahar <[email protected]> wrote: > > Hello All, > > i've fixed the code according to JC update to Readlines > the latest update : > https://github.com/hadyelsahar/extraction-framework/commit/da3ddb8ee6d1274ca575805258e9bfb3603d82d7
Looks good! > > >> I implemented the first solution (last value is null): >> >> https://github.com/dbpedia/extraction-framework/commit/c8d2f8b61b6bd868cbdc7b78f2ca28253bd4acd5 >> >> It's on the dump branch, but I guess you can copy it over or so. >> >> I tried the Option[String] solution first, but I found that I had to >> make more intrusive changes to the existing code. And in general, I >> often find Scala's match/case structures less readable than >> if-then-else. For example, in your case, you probably need to handle >> the case line == null in the same code block as the case line != null, >> so you can hardly use match/case. But I may be wrong, I'm not a Scala >> expert. > > > does that mean that we have to update each line of code using the ReadLines > function in the extraction framework to check for null? Yes, I already did that (on the dump branch). Took about ten minutes. When I make changes that breaks other code, I fix these other places. I don't commit code that I know to be broken. The code in the main repo should always compile and run. Regards, JC > > > > thanks > Regards > ------------------------------------------------- > Hady El-Sahar > Research Assistant > Center of Informatics Sciences | Nile University > > email : [email protected] > Phone : +2-01220887311 > http://hadyelsahar.me/ > > > ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk _______________________________________________ Dbpedia-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dbpedia-developers
