Fine now, I pushed the changes.
One issue as I figured when I went to the github repo, I opened one of the
files that I've changed "DateTimeParserConfig.scala", I noticed that the
Arabic text is making some trouble there because as you know Arabic is
written from right to left.
Will that make a problem or it's ok ?
Best regards;
On 25 March 2013 18:40, Ahmed Ktob <[email protected]> wrote:
> I did something wrong, I am using Windows 7 with Intellij IDEA, it's
> little confusing, but I am going to try it again.
>
>
> On 25 March 2013 18:33, Jona Christopher Sahnwaldt <[email protected]>wrote:
>
>> Hi Ahmed,
>>
>> On 25 March 2013 17:44, Ahmed Ktob <[email protected]> wrote:
>> > Alright, I committed the changes, I hope someone will review them.
>>
>> It looks like this didn't quite work. I don't see a pull request here:
>> https://github.com/dbpedia/extraction-framework/pulls
>> Did you send a pull request? (Step 7 in
>> https://github.com/dbpedia/extraction-framework/wiki/Contributing )
>>
>> JC
>>
>> >
>> > On 25 March 2013 17:32, Ahmed Ktob <[email protected]> wrote:
>> >>
>> >> Hello Jona,
>> >>
>> >> Thank you so much, I am going to follow the instructions on that link,
>> in
>> >> case I face some problems, I will be back.
>> >>
>> >> On 25 March 2013 17:30, Jona Christopher Sahnwaldt <[email protected]>
>> >> wrote:
>> >>>
>> >>> On 25 March 2013 17:21, Ahmed Ktob <[email protected]> wrote:
>> >>> > Hello guys,
>> >>> >
>> >>> > I have made some changes to the following files (I added the Arabic
>> >>> > configuration) :
>> >>> > In the path "main/scala/org.dbpedia.extraction/config/dataparser
>> >>> >
>> >>> > DateTimeParserConfig.scala
>> >>> > DurationParserConfig.scala
>> >>> > FlagTemplateParserConfig.scala
>> >>> > ParserUtilsConfig.scala
>> >>> >
>> >>> > In the path "main/scala/org.dbpedia.extraction/config/mappings
>> >>> >
>> >>> > DateIntervalMappingConfig.scala
>> >>> > DisambiguationExtractorConfig.scala
>> >>> > HomepageExtractorConfig.scala
>> >>> > ImageExtractorConfig.scala
>> >>> > InfoboxExtractorConfig.scala
>> >>> > TopicalConceptsExtractorConfig.scala
>> >>> >
>> >>>
>> >>> That's great!
>> >>>
>> >>> > My question is should I commit these changes now or there are some
>> >>> > steps
>> >>> > that I should follow ?
>> >>>
>> >>> I am not a git or github expert, but I think these instructions will
>> help
>> >>> you:
>> >>>
>> >>> https://github.com/dbpedia/extraction-framework/wiki/Contributing
>> >>>
>> >>> If you have any questions, feel free to ask us!
>> >>>
>> >>> Welcome to DBpedia!
>> >>>
>> >>> Cheers,
>> >>> JC
>> >>>
>> >>> > Thank you so much.
>> >>> >
>> >>> > Best regards;
>> >>> > Ahmed.
>> >>> > --
>> >>> > ------------------------------------------------
>> >>> > Ahmed Ktob
>> >>> > Dr. Taher Moulay University
>> >>> > Department of Computer Science
>> >>> > Saida , Algeria
>> >>> > Tel : +213 554 811 151
>> >>> > ------------------------------------------------
>> >>> >
>> >>> >
>> >>> >
>> ------------------------------------------------------------------------------
>> >>> > Everyone hates slow websites. So do we.
>> >>> > Make your web apps faster with AppDynamics
>> >>> > Download AppDynamics Lite for free today:
>> >>> > http://p.sf.net/sfu/appdyn_d2d_mar
>> >>> > _______________________________________________
>> >>> > Dbpedia-discussion mailing list
>> >>> > [email protected]
>> >>> > https://lists.sourceforge.net/lists/listinfo/dbpedia-discussion
>> >>> >
>> >>
>> >>
>> >>
>> >>
>> >> --
>> >> ------------------------------------------------
>> >> Ahmed Ktob
>> >> Dr. Taher Moulay University
>> >> Department of Computer Science
>> >> Saida , Algeria
>> >> Tel : +213 554 811 151
>> >> ------------------------------------------------
>> >
>> >
>> >
>> >
>> > --
>> > ------------------------------------------------
>> > Ahmed Ktob
>> > Dr. Taher Moulay University
>> > Department of Computer Science
>> > Saida , Algeria
>> > Tel : +213 554 811 151
>> > ------------------------------------------------
>>
>
>
>
> --
> *------------------------------------------------
> **Ahmed Ktob
> Dr. Taher Moulay* *University * *
> Department of Computer Science*
> *Saida , Algeria*
> *Tel : +213 554 811 151**
> ------------------------------------------------*
>
--
*------------------------------------------------
**Ahmed Ktob
Dr. Taher Moulay* *University * *
Department of Computer Science*
*Saida , Algeria*
*Tel : +213 554 811 151**
------------------------------------------------*
------------------------------------------------------------------------------
Own the Future-Intel® Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest.
Compete for recognition, cash, and the chance to get your game
on Steam. $5K grand prize plus 10 genre and skill prizes.
Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d
_______________________________________________
Dbpedia-discussion mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dbpedia-discussion