Thank you so much for your review, I hope it will do what it is supposed to
do. ))
Cheers,
Ahmed.
On 26 March 2013 00:14, Jona Christopher Sahnwaldt <[email protected]> wrote:
> Hi Ahmed,
>
> I think your code is correct. I will merge your pull request soon.
>
> Details:
>
> I looked at the Scala file in several different programs, and it looks
> different each time. Each program seems to have its own heuristic -
> something like "oh, there's an Arabic character, let's switch to
> right-to-left rendering". Some programs switch back to left-to-right
> at the next line, others when they find the next Latin character. Or
> something like this. Interesting. But each heuristic makes the text
> look as if it was invalid Scala code.
>
> Anyway, a hex dump is more reliable:
>
> > curl
> https://raw.github.com/ktobah/extraction-framework/ArabicConfiguration/core/src/main/scala/org/dbpedia/extraction/config/dataparser/DateTimeParserConfig.scala|
> hexdump -C | less
>
> [snip]
>
> 000009d0 29 2c 0a 20 20 20 20 20 20 20 20 22 61 72 22 20 |),.
> "ar" |
> 000009e0 2d 3e 20 4d 61 70 28 22 d8 ac d8 a7 d9 86 d9 81 |->
> Map("........|
> 000009f0 d9 8a 22 2d 3e 31 2c 22 d9 81 d9 8a d9 81 d8 b1
> |.."->1,"........|
> 00000a00 d9 8a 22 2d 3e 32 2c 22 d9 85 d8 a7 d8 b1 d8 b3
> |.."->2,"........|
> 00000a10 22 2d 3e 33 2c 22 d8 a3 d9 81 d8 b1 d9 8a d9 84
> |"->3,"..........|
> 00000a20 22 2d 3e 34 2c 22 d9 85 d8 a7 d9 8a 22 2d 3e 35
> |"->4,"......"->5|
> 00000a30 2c 22 d8 ac d9 88 d8 a7 d9 86 22 2d 3e 36 2c 22
> |,"........"->6,"|
> 00000a40 d8 ac d9 88 d9 8a d9 84 d9 8a d8 a9 22 2d 3e 37
> |............"->7|
> 00000a50 2c 22 d8 a3 d9 88 d8 aa 22 2d 3e 38 2c 22 d8 b3
> |,"......"->8,"..|
> 00000a60 d8 a8 d8 aa d9 85 d8 a8 d8 b1 22 2d 3e 39 2c 22
> |.........."->9,"|
> 00000a70 d8 a3 d9 83 d8 aa d9 88 d8 a8 d8 b1 22 2d 3e 31
> |............"->1|
> 00000a80 30 2c 22 d9 86 d9 88 d9 81 d9 85 d8 a8 d8 b1 22
> |0,"............"|
> 00000a90 2d 3e 31 31 2c 22 d8 af d9 8a d8 b3 d9 85 d8 a8
> |->11,"..........|
> 00000aa0 d8 b1 22 2d 3e 31 32 2c 0a 20 20 20 20 20 20 20 |.."->12,.
> |
> 00000ab0 20 20 20 20 20 20 20 20 20 20 20 20 22 d9 8a d9 |
> "...|
> 00000ac0 86 d8 a7 d9 8a d8 b1 22 2d 3e 31 2c 22 d9 81 d8
> |......."->1,"...|
> 00000ad0 a8 d8 b1 d8 a7 d9 8a d8 b1 22 2d 3e 32 2c 22 d8
> |........."->2,".|
> 00000ae0 a3 d8 a8 d8 b1 d9 8a d9 84 22 2d 3e 34 2c 22 d9
> |........."->4,".|
> 00000af0 85 d8 a7 d9 8a d9 88 22 2d 3e 35 2c 22 d9 8a d9
> |......."->5,"...|
> 00000b00 88 d9 86 d9 8a d9 88 22 2d 3e 36 2c 22 d9 8a d9
> |......."->6,"...|
> 00000b10 88 d9 84 d9 8a d9 88 22 2d 3e 37 2c 22 d9 8a d9
> |......."->7,"...|
> 00000b20 88 d9 84 d9 8a d9 88 d8 b2 22 2d 3e 37 2c 22 d8
> |........."->7,".|
> 00000b30 a3 d8 ba d8 b3 d8 b7 d8 b3 22 2d 3e 38 2c 22 d8
> |........."->8,".|
> 00000b40 ba d8 b4 d8 aa 22 2d 3e 38 2c 22 d8 b4 d8 aa d9
> |....."->8,".....|
> 00000b50 86 d8 a8 d8 b1 22 2d 3e 39 2c 22 d9 86 d9 88 d9
> |....."->9,".....|
> 00000b60 86 d8 a8 d8 b1 22 2d 3e 31 31 2c 22 d8 af d8 ac
> |....."->11,"....|
> 00000b70 d9 86 d8 a8 d8 b1 22 2d 3e 31 32 29 2c 0a 20 20
> |......"->12),. |
>
> Now I'm pretty sure the code is syntactically correct.
>
> I can't read Arabic and don't know much about the right-to-left
> handling in Java/Scala, so I don't know if it does what it's supposed
> to do, but I like puzzles, so I tried a few more things. This the
> Arabic wikipedia page about the month January:
>
>
> http://ar.wikipedia.org/wiki/%D9%8A%D9%86%D8%A7%D9%8A%D8%B1_(%D8%B4%D9%87%D8%B1)
>
> The UTF-8 bytes <d9 8a d9 86 d8 a7 d9 8a d8 b1> in the URL encode the
> word يناير (Arabic for January), also appear in the page text and, in
> the same order, as the first key in the second line of the Arabic map
> in your Scala code. Looks good to me. :-)
>
> Cheers,
> JC
>
> On 25 March 2013 23:11, Ahmed Ktob <[email protected]> wrote:
> > Thank you so much Joan, here is the link, take a look please:
> >
> > https://github.com/ktobah/extraction-framework/tree/ArabicConfiguration
> >
> > On 25 March 2013 23:09, Jona Christopher Sahnwaldt <[email protected]>
> wrote:
> >>
> >> Hi Ahmed,
> >>
> >> please send us a link to your files on github. I don't know much about
> >> right-to-left problems, but I'd like to take a look.
> >>
> >> Your fork is not visible on
> >> https://github.com/dbpedia/extraction-framework/network
> >> I think it should, but I don't know much about github though.
> >>
> >> Cheers,
> >> JC
> >>
> >> On 25 March 2013 23:03, Ahmed Ktob <[email protected]> wrote:
> >> > Fine now, I pushed the changes.
> >> >
> >> > One issue as I figured when I went to the github repo, I opened one
> of
> >> > the
> >> > files that I've changed "DateTimeParserConfig.scala", I noticed that
> the
> >> > Arabic text is making some trouble there because as you know Arabic is
> >> > written from right to left.
> >> >
> >> > Will that make a problem or it's ok ?
> >> >
> >> > Best regards;
> >> >
> >> > On 25 March 2013 18:40, Ahmed Ktob <[email protected]> wrote:
> >> >>
> >> >> I did something wrong, I am using Windows 7 with Intellij IDEA, it's
> >> >> little confusing, but I am going to try it again.
> >> >>
> >> >>
> >> >> On 25 March 2013 18:33, Jona Christopher Sahnwaldt <[email protected]>
> >> >> wrote:
> >> >>>
> >> >>> Hi Ahmed,
> >> >>>
> >> >>> On 25 March 2013 17:44, Ahmed Ktob <[email protected]> wrote:
> >> >>> > Alright, I committed the changes, I hope someone will review them.
> >> >>>
> >> >>> It looks like this didn't quite work. I don't see a pull request
> here:
> >> >>> https://github.com/dbpedia/extraction-framework/pulls
> >> >>> Did you send a pull request? (Step 7 in
> >> >>> https://github.com/dbpedia/extraction-framework/wiki/Contributing )
> >> >>>
> >> >>> JC
> >> >>>
> >> >>> >
> >> >>> > On 25 March 2013 17:32, Ahmed Ktob <[email protected]> wrote:
> >> >>> >>
> >> >>> >> Hello Jona,
> >> >>> >>
> >> >>> >> Thank you so much, I am going to follow the instructions on that
> >> >>> >> link,
> >> >>> >> in
> >> >>> >> case I face some problems, I will be back.
> >> >>> >>
> >> >>> >> On 25 March 2013 17:30, Jona Christopher Sahnwaldt
> >> >>> >> <[email protected]>
> >> >>> >> wrote:
> >> >>> >>>
> >> >>> >>> On 25 March 2013 17:21, Ahmed Ktob <[email protected]> wrote:
> >> >>> >>> > Hello guys,
> >> >>> >>> >
> >> >>> >>> > I have made some changes to the following files (I added the
> >> >>> >>> > Arabic
> >> >>> >>> > configuration) :
> >> >>> >>> > In the path
> "main/scala/org.dbpedia.extraction/config/dataparser
> >> >>> >>> >
> >> >>> >>> > DateTimeParserConfig.scala
> >> >>> >>> > DurationParserConfig.scala
> >> >>> >>> > FlagTemplateParserConfig.scala
> >> >>> >>> > ParserUtilsConfig.scala
> >> >>> >>> >
> >> >>> >>> > In the path
> "main/scala/org.dbpedia.extraction/config/mappings
> >> >>> >>> >
> >> >>> >>> > DateIntervalMappingConfig.scala
> >> >>> >>> > DisambiguationExtractorConfig.scala
> >> >>> >>> > HomepageExtractorConfig.scala
> >> >>> >>> > ImageExtractorConfig.scala
> >> >>> >>> > InfoboxExtractorConfig.scala
> >> >>> >>> > TopicalConceptsExtractorConfig.scala
> >> >>> >>> >
> >> >>> >>>
> >> >>> >>> That's great!
> >> >>> >>>
> >> >>> >>> > My question is should I commit these changes now or there are
> >> >>> >>> > some
> >> >>> >>> > steps
> >> >>> >>> > that I should follow ?
> >> >>> >>>
> >> >>> >>> I am not a git or github expert, but I think these instructions
> >> >>> >>> will
> >> >>> >>> help
> >> >>> >>> you:
> >> >>> >>>
> >> >>> >>>
> https://github.com/dbpedia/extraction-framework/wiki/Contributing
> >> >>> >>>
> >> >>> >>> If you have any questions, feel free to ask us!
> >> >>> >>>
> >> >>> >>> Welcome to DBpedia!
> >> >>> >>>
> >> >>> >>> Cheers,
> >> >>> >>> JC
> >> >>> >>>
> >> >>> >>> > Thank you so much.
> >> >>> >>> >
> >> >>> >>> > Best regards;
> >> >>> >>> > Ahmed.
> >> >>> >>> > --
> >> >>> >>> > ------------------------------------------------
> >> >>> >>> > Ahmed Ktob
> >> >>> >>> > Dr. Taher Moulay University
> >> >>> >>> > Department of Computer Science
> >> >>> >>> > Saida , Algeria
> >> >>> >>> > Tel : +213 554 811 151
> >> >>> >>> > ------------------------------------------------
> >> >>> >>> >
> >> >>> >>> >
> >> >>> >>> >
> >> >>> >>> >
> >> >>> >>> >
> ------------------------------------------------------------------------------
> >> >>> >>> > Everyone hates slow websites. So do we.
> >> >>> >>> > Make your web apps faster with AppDynamics
> >> >>> >>> > Download AppDynamics Lite for free today:
> >> >>> >>> > http://p.sf.net/sfu/appdyn_d2d_mar
> >> >>> >>> > _______________________________________________
> >> >>> >>> > Dbpedia-discussion mailing list
> >> >>> >>> > [email protected]
> >> >>> >>> >
> https://lists.sourceforge.net/lists/listinfo/dbpedia-discussion
> >> >>> >>> >
> >> >>> >>
> >> >>> >>
> >> >>> >>
> >> >>> >>
> >> >>> >> --
> >> >>> >> ------------------------------------------------
> >> >>> >> Ahmed Ktob
> >> >>> >> Dr. Taher Moulay University
> >> >>> >> Department of Computer Science
> >> >>> >> Saida , Algeria
> >> >>> >> Tel : +213 554 811 151
> >> >>> >> ------------------------------------------------
> >> >>> >
> >> >>> >
> >> >>> >
> >> >>> >
> >> >>> > --
> >> >>> > ------------------------------------------------
> >> >>> > Ahmed Ktob
> >> >>> > Dr. Taher Moulay University
> >> >>> > Department of Computer Science
> >> >>> > Saida , Algeria
> >> >>> > Tel : +213 554 811 151
> >> >>> > ------------------------------------------------
> >> >>
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> ------------------------------------------------
> >> >> Ahmed Ktob
> >> >> Dr. Taher Moulay University
> >> >> Department of Computer Science
> >> >> Saida , Algeria
> >> >> Tel : +213 554 811 151
> >> >> ------------------------------------------------
> >> >
> >> >
> >> >
> >> >
> >> > --
> >> > ------------------------------------------------
> >> > Ahmed Ktob
> >> > Dr. Taher Moulay University
> >> > Department of Computer Science
> >> > Saida , Algeria
> >> > Tel : +213 554 811 151
> >> > ------------------------------------------------
> >
> >
> >
> >
> > --
> > ------------------------------------------------
> > Ahmed Ktob
> > Dr. Taher Moulay University
> > Department of Computer Science
> > Saida , Algeria
> > Tel : +213 554 811 151
> > ------------------------------------------------
>
--
*------------------------------------------------
**Ahmed Ktob
Dr. Taher Moulay* *University * *
Department of Computer Science*
*Saida , Algeria*
*Tel : +213 554 811 151**
------------------------------------------------*
------------------------------------------------------------------------------
Own the Future-Intel® Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest.
Compete for recognition, cash, and the chance to get your game
on Steam. $5K grand prize plus 10 genre and skill prizes.
Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d
_______________________________________________
Dbpedia-discussion mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dbpedia-discussion
