Hi, yes I understand. Attached is the patch to the questionable missing break which is when missining intentional strange and should at least be documented.
One more question I don't see any code that deals with the situations where one changes e.g. the name of column/table, removes a column/table, ... which is referenced in indices, foreign keys, ... . Tom Thomas Dudziak wrote: > On 4/20/06, Tom Schindl <[EMAIL PROTECTED]> wrote: > > >>if just installed the TPTP-Plugin and started an analyzing run and it >>shows up 7575 more of less questionable results, starting from missing >>breaks in switch case block to hardcoded \r\n's. >> >>Should I provide patches to calm down the analyzer because then it would >> may spot better really questionable constructs like the above >>mentionned missing breaks. > > > You should take these with a big grain of salt. A default > configuration of PMD would probably show about the same amount of > 'issues', but a lot of these are either personal style (e.g. number of > 'duplicated strings' which does not work well when logging is used > heavily) , or have to be analyzed manually (such as the 'missing > break' which might or might not be intentional). > As it is, I'm quite satisified with the code style-wise (not to > mention that DdlUtils has a configured Checkstyle process which works > nicely), so I'd rather not start with this. > > Once the 1.0 is out, I probably configure PMD in order to enhance the > code review process, but currently IMO it would be way more beneficial > to finish the 1.0 which only misses the revised alteration algorithm > that I'm currently working on, and a few of the issues that make sense > for the 1.0. > > cheers, > Tom > >
Index:
E:/eclipse-workspaces/beso-oo/commons-sql/src/java/org/apache/ddlutils/platform/DefaultValueHelper.java
===================================================================
---
E:/eclipse-workspaces/beso-oo/commons-sql/src/java/org/apache/ddlutils/platform/DefaultValueHelper.java
(revision 395374)
+++
E:/eclipse-workspaces/beso-oo/commons-sql/src/java/org/apache/ddlutils/platform/DefaultValueHelper.java
(working copy)
@@ -79,6 +79,7 @@
catch (IllegalArgumentException ex)
{}
}
+ break;
default:
if (Jdbc3Utils.supportsJava14JdbcTypes() &&
(originalTypeCode ==
Jdbc3Utils.determineBooleanTypeCode()))
signature.asc
Description: OpenPGP digital signature
