On Mon, Mar 08, 2010 at 03:02:45PM -0300, Otavio Salvador wrote: > On Mon, Mar 8, 2010 at 3:00 PM, Frans Pop <[email protected]> wrote: > > On Monday 08 March 2010, Colin Watson wrote: > > > I'd like to commit the following patch to make grub-installer use > > > grub-probe, as noted in a TODO comment, rather than the huge > > > hand-written pile of incomprehensible shell that's been there since time > > > immemorial. Does anyone object to this? > > > > How does this affect the use of grub-legacy? > > grub-legacy also uses grub-probe.
Indeed, what he said. grub-probe is in grub-common exactly so that both grub-legacy and grub2 can use it, and note that there's a bit of code in my patch to handle the different partition number offset. BTW, the real reason I care about this beyond just code reduction is that there are bugs that we can't really sanely fix until we stop writing out a device.map file by default (for example, what happens when you add a new disk?). grub2 itself can function now without a device.map - the things that still care are things like grub-installer, and I'd like to get rid of those dependencies so that we can change grub2 to stop writing device.map without breaking the installer. After this patch, grub-installer will no longer care if device.map is absent. (grub-legacy, of course, will write out its own device.map because it needs it. That's up to it.) -- Colin Watson [[email protected]] -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/[email protected]
