Your message dated Wed, 8 Apr 2020 10:56:55 +0200
with message-id <[email protected]>
and subject line Closing bug report
has caused the Debian Bug report #655198,
regarding live-installer does not remove live packages in the installed system
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
655198: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=655198
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: live-installer
Version: 34
Severity: normal
Tags: d-i patch

Dear Maintainer,

I've noticed that debian-installer-launcher was not removed in the 
installed system, as were not removed also live-config, live-boot and 
others.

The problem was that a missing var initialization of do_manual_removal 
in finish-install.d/60remove-live-packages, preventing the packages to 
be manually removed by default.

        do_manual_removal=true

Related to this is the search for /cdrom/live/filesystem.packages-remove 
file. I suppose the /cdrom is not mounted when 
finish-install.d/60remove-live-packages is executed, so the file 
/cdrom/live/filesystem.packages-remove is not found, and I can confirm 
that the file *is* in the image.

        /usr/lib/finish-install.d # ls
        01kickseed
        05crypto
        05localechooser
        06user-setup
        07brltty
        07preseed
        07speakup
        10apt-cdrom-setup
        10clock-setup
        15cdrom-detect
        20final-message
        30hw-detect
        50config-target-network
        55netcfg-network-manager
        60cleanup
        60remove-live-packages
        65partman-md
        90base-installer
        90console
        94save-logs
        95umount
        97release-dhcp-lease
        98exit-installer
        99reboot

        /usr/lib/finish-install.d # grep /cdrom *
        10apt-cdrom-setup:if [ -e /cdrom/.disk/base_installable ] && \
        10apt-cdrom-setup:   [ -e /cdrom/.disk/cd_type ] && \
        10apt-cdrom-setup:   [ "$(cat /cdrom/.disk/cd_type)" = not_complete ] 
&& \
        10apt-cdrom-setup:      sed -i "/^deb cdrom:/s/^/#/" 
/target/etc/apt/sources.list
        15cdrom-detect: logger -t cdrom-detect "$@"
        15cdrom-detect:# Cannot just tell eject to eject /cdrom as it is not 
compatible
        15cdrom-detect:# with busybox umount. Instead, unmount the cdrom first, 
and then
        15cdrom-detect:CDDEV=$(mount | grep "on /cdrom" | cut -d ' ' -f 1)
        15cdrom-detect: umount /cdrom || true
        15cdrom-detect: db_get cdrom-detect/eject
        60remove-live-packages:for list in 
/cdrom/live/filesystem.packages-remove; do

I could not find any mount or umount command in 
/usr/lib/finish-install.d/*, just in 15cdrom-detect. Maybe it's 
15cdrom-detect that umounts the /cdrom. If it is "cdrom-detect" is 
misleading.

If that's the case then something should be done. Move 
60remove-live-packages to before 15cdrom-detect (or vice-versa), or just 
remove "manually" the live packages, or something else.

Anyway, to fix/workaroung the original problem by removing manually the 
packages, adding the variable an initial value makes the "manual" 
removal happen.

Patch attached. Thank you.

>From 20ba218a7b3507a5cba54b78e6453b387aa4dc3a Mon Sep 17 00:00:00 2001
From: "Rui Miguel P. Bernardo" <[email protected]>
Date: Mon, 9 Jan 2012 06:07:25 +0000
Subject: [PATCH] Initialize do_manual_removal var.

---
 finish-install.d/60remove-live-packages |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/finish-install.d/60remove-live-packages 
b/finish-install.d/60remove-live-packages
index aab6db2..a70466e 100755
--- a/finish-install.d/60remove-live-packages
+++ b/finish-install.d/60remove-live-packages
@@ -1,5 +1,7 @@
 #!/bin/sh -e
 
+do_manual_removal=true
+
 # Remove packages as specified in specific package removal list
 for list in /cdrom/live/filesystem.packages-remove; do
        if [ -e $list ]; then
-- 
1.7.7.1




-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0-1-amd64 (SMP w/1 CPU core)
Locale: LANG=pt_PT.UTF-8, LC_CTYPE=pt_PT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
>From 20ba218a7b3507a5cba54b78e6453b387aa4dc3a Mon Sep 17 00:00:00 2001
From: "Rui Miguel P. Bernardo" <[email protected]>
Date: Mon, 9 Jan 2012 06:07:25 +0000
Subject: [PATCH] Initialize do_manual_removal var.

---
 finish-install.d/60remove-live-packages |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/finish-install.d/60remove-live-packages b/finish-install.d/60remove-live-packages
index aab6db2..a70466e 100755
--- a/finish-install.d/60remove-live-packages
+++ b/finish-install.d/60remove-live-packages
@@ -1,5 +1,7 @@
 #!/bin/sh -e
 
+do_manual_removal=true
+
 # Remove packages as specified in specific package removal list
 for list in /cdrom/live/filesystem.packages-remove; do
 	if [ -e $list ]; then
-- 
1.7.7.1


--- End Message ---
--- Begin Message ---
Squeeze is no longer supported, and since this bug only affects
live-config in squeeze, I'm closing it now.

--- End Message ---

Reply via email to