Hey Alper, Apologies, I've been swamped with a lot of other things lately, both in Debian and in starting up with a new day job. I'll try and review your more recent changes shortly...
On Wed, Jul 01, 2020 at 07:46:39PM +0300, Alper Nebi Yasak wrote: >Hi, I just wanted to remind you of some patches I sent a while back. Do you >(or anyone else) have time to comment on / review / merge them? > >On 19/05/2020 17:17, Alper Nebi Yasak wrote: >> So I tested my earlier patch, and did a bit more. I've attached three >> patches, first two for debian-installer and the third for rootskel. >> >> The first patch fixes arm64 netboot and netboot-gtk mini.iso images >> which now have 'Graphical install' GRUB entries using /gtk/initrd.gz >> files which don't exist, by making that file identical to /initrd.gz. > >Also, instead of this, would it be fine to merge netboot-gtk into netboot in >general? I think that would solve this issue better. > >> The second patch adds "console=tty0" to GRUB entries marked as >> "Graphical" in grub-gencfg. Without this, "Graphical automated install" >> runs on the serial console (since that may be the "preferred" console >> due to stdout-path or SPCR on arm64). The console=tty0 cmdline argument >> also ends up in the installed system's /etc/default/grub.cfg, which is >> correct IMO. >> >> The third patch considers tty0 a possible console even if it's not in >> /proc/consoles (the patch I sent earlier). The text-mode installer >> already launches on the display in the stdout-path case, but not on the >> SPCR case. With this it launches on the display in that case as well. >> >> I've tested on an arm64 QEMU VM. After all the patches: >> - "Install" launches on serial and display >> - "Graphical install" launches on display and serial >> - "Automated install" launches only on serial >> - "Graphical automated install" launches only on display >> >> On systems where console is set with stdout-path instead, "Graphical >> install" would launch only on display, but the others would be the same. > >The three patches are available at [1] if you haven't received them, or I can >resend them if you want. > >[1] https://lists.debian.org/debian-boot/2020/05/msg00178.html > >There's also a small change I posted for bug #961590 [2] that includes >fb-modules in the netboot pkg-list, I'd be glad if that could be merged as >well. > >[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=961590#30 > -- Steve McIntyre, Cambridge, UK. st...@einval.com Mature Sporty Personal More Innovation More Adult A Man in Dandism Powered Midship Specialty
